Sign upLogin

huridocs/uwazi

View on GitHub
Star
app/react/Metadata/components/MetadataFormFields.js

Summary

Maintainability
C
1 day
Test Coverage
F
54%

Function getField has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  getField(property, _model, thesauris, formModel) {
    let thesauri;
    let totalPossibleOptions = 0;
    const {
      dateFormat,
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (property.targetTemplates.length === 0) {
          thesauri = Array.prototype
            .concat(
              ...thesauris
                .filter(filterThesauri => filterThesauri.get('type') === 'template')
Severity: Major
Found in app/react/Metadata/components/MetadataFormFields.js and 1 other location - About 3 hrs to fix
app/react/Metadata/components/MetadataFormFields.js on lines 187..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!property.content) {
          thesauri = Array.prototype
            .concat(
              ...thesauris
                .filter(filterThesauri => filterThesauri.get('type') === 'template')
Severity: Major
Found in app/react/Metadata/components/MetadataFormFields.js and 1 other location - About 3 hrs to fix
app/react/Metadata/components/MetadataFormFields.js on lines 239..250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        return (
          <LookupMultiSelect
            lookup={getSuggestions.bind(null, property.content ? [property.content] : [])}
            model={_model}
            optionsValue="id"
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js and 1 other location - About 55 mins to fix
app/react/Metadata/components/MetadataFormFields.js on lines 261..272

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        return (
          <LookupMultiSelect
            lookup={getSuggestions.bind(null, property.content ? [property.content] : [])}
            model={_model}
            optionsValue="id"
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js and 1 other location - About 55 mins to fix
app/react/Metadata/components/MetadataFormFields.js on lines 209..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Definition for rule 'node/no-restricted-import' was not found.
Open

/* eslint-disable max-statements */
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Prefer named exports.
Open

export default connect(mapStateToProps, mapDispatchToProps)(MetadataFormFields);
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

JSX props should not use .bind()
Open

            onChange={this.relationshipChange.bind(this, property)}
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

A control must be associated with a text label.
Open

            <input
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

JSX props should not use .bind()
Wontfix

            lookup={getSuggestions.bind(null, property.content ? [property.content] : [])}
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

A control must be associated with a text label.
Open

            <input type="text" className="form-control" />
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

JSX props should not use .bind()
Wontfix

            lookup={getSuggestions.bind(null, property.content ? [property.content] : [])}
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

JSX props should not use .bind()
Open

            onChange={this.relationshipChange.bind(this, property)}
Severity: Minor
Found in app/react/Metadata/components/MetadataFormFields.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status