Sign upLogin

hybridgroup/cylon-beaglebone

View on GitHub
Star
lib/beaglebone.js

Summary

Maintainability
C
1 day
Test Coverage

File beaglebone.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Cylonjs Beaglebone adaptor
 * http://cylonjs.com
 *
 * Copyright (c) 2013-2014 The Hybrid Group
Severity: Minor
Found in lib/beaglebone.js - About 2 hrs to fix

    Function _muxPin has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Beaglebone.prototype._muxPin = function(type, args) {
  var pin, gpioPinNum;

  switch (type) {
    case "pwm":
    Severity: Minor
    Found in lib/beaglebone.js - About 1 hr to fix

      Function pwmWrite has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      Beaglebone.prototype.pwmWrite = function(pin, scaledDuty, freq, pw, event, cb) {
      Severity: Minor
      Found in lib/beaglebone.js - About 45 mins to fix

        Function servoWrite has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        Beaglebone.prototype.servoWrite = function(pin, scaledDuty, freq, pw, cb) {
        Severity: Minor
        Found in lib/beaglebone.js - About 35 mins to fix

          Function _pwmWrite has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          Beaglebone.prototype._pwmWrite = function(pinNum, period, duty, eName, cb) {
          Severity: Minor
          Found in lib/beaglebone.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case "digital":
      gpioPinNum = this._translatePin(args.pinNum);
      pin = this.pins[gpioPinNum] ||
            this._newDigitalPin(gpioPinNum, args.mode);
      this.pins[gpioPinNum] = pin;
            Severity: Major
            Found in lib/beaglebone.js and 1 other location - About 1 hr to fix
            lib/beaglebone.js on lines 399..404

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case "pwm":
      gpioPinNum = this._translatePwmPin(args.pinNum);
      pin = this.pwmPins[gpioPinNum] ||
            this._newPwmPin(gpioPinNum, args.period);
      this.pwmPins[gpioPinNum] = pin;
            Severity: Major
            Found in lib/beaglebone.js and 1 other location - About 1 hr to fix
            lib/beaglebone.js on lines 411..416

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                pin.on("digitalRead", function(val) {
      this.respond("digitalRead", callback, null, val, pinNum);
    }.bind(this));
            Severity: Minor
            Found in lib/beaglebone.js and 2 other locations - About 30 mins to fix
            lib/beaglebone.js on lines 204..206
            lib/beaglebone.js on lines 278..280

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                pin.on("digitalWrite", function(val) {
      this.respond("digitalWrite", callback, null, val, pinNum);
    }.bind(this));
            Severity: Minor
            Found in lib/beaglebone.js and 2 other locations - About 30 mins to fix
            lib/beaglebone.js on lines 204..206
            lib/beaglebone.js on lines 242..244

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                pin.on("analogRead", function(val) {
      this.respond("analogRead", callback, null, val, pinNum);
    }.bind(this));
            Severity: Minor
            Found in lib/beaglebone.js and 2 other locations - About 30 mins to fix
            lib/beaglebone.js on lines 242..244
            lib/beaglebone.js on lines 278..280

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status