Sign upLogin

hybridgroup/cylon-nest

View on GitHub
Star

Showing 6 of 30 total issues

Function work has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  work: function(my) {
    my.thermostat.on("status", function() {
      console.log("========================Thermostat=======================");
      console.log("id:",
        my.thermostat.deviceId);
Severity: Major
Found in examples/api-tester/thermostat-api.js - About 2 hrs to fix

    Function setupCommands has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      setupCommands: function(commands, source, target) {
    var self = this;
    commands.forEach(function(command) {

      target[command] = function(val, structureId) {
    Severity: Minor
    Found in lib/utils.js - About 1 hr to fix

      Function command has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            target[command] = function(val, structureId) {
        if (command === "structures") {
          return source;
        }
        var specialCmds = ["structureName", "deviceName"];
      Severity: Minor
      Found in lib/utils.js - About 1 hr to fix

        Function read has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        Nest.prototype.read = function(key, structureId, callback) {
  var sId = null;

  if (typeof structureId === "function") {
    callback = structureId;
        Severity: Minor
        Found in lib/nest-home.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                      return target.write(self.toSnakeCase(command), val);
        Severity: Major
        Found in lib/utils.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return res;
          Severity: Major
          Found in lib/utils.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language