hyperoslo/openid-token-proxy

View on GitHub

Showing 4 of 4 total issues

Method retrieve_token! has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def retrieve_token!(params)
      client = new_client

      if auth_code = params.delete(:auth_code)
        client.authorization_code = auth_code
Severity: Minor
Found in lib/openid_token_proxy/client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def validate!(assertions = {})
      raise Expired if expired?

      # TODO: Nonce validation

Severity: Minor
Found in lib/openid_token_proxy/token.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method require_valid_token has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def require_valid_token
          super
        rescue OpenIDTokenProxy::Token::Expired
          raise unless raw_refresh_token.present?
          @current_token = OpenIDTokenProxy.client.retrieve_token!(
Severity: Minor
Found in lib/openid_token_proxy/token/refresh.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def handle
        unless code = params[:code]
          render text: "Required parameter 'code' missing.", status: :bad_request
          return
        end
Severity: Minor
Found in lib/openid_token_proxy/concerns/callback_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language