Sign upLogin

iMattPro/dbtool

View on GitHub
Star

Showing 7 of 7 total issues

Method display_tables has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function display_tables()
    {
        $table_data = [];
        $total_data_size = $total_data_free = 0;
Severity: Minor
Found in acp/dbtool_module.php - About 1 hr to fix

    Method execute has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);

        if (!$this->db_tool->is_mysql())
    Severity: Minor
    Found in console/command/db/tool.php - About 1 hr to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(user $user, db $db, phpbb_db_tools $phpbb_db_tools, db_tool $db_tool, db_lock $db_lock, language $language)
      Severity: Minor
      Found in console/command/db/tool.php - About 45 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(cache $cache, config $config, db $db, log $log, user $user)
        Severity: Minor
        Found in tool/tool.php - About 35 mins to fix

          Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);

        if (!$this->db_tool->is_mysql())
          Severity: Minor
          Found in console/command/db/tool.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function run_tool has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function run_tool()
    {
        $operation = strtoupper($this->request->variable('operation', ''));
        $tables = $this->request->variable('mark', ['']);
        $disable_board = $this->request->variable('disable_board', 0);
          Severity: Minor
          Found in acp/dbtool_module.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function display_tables has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function display_tables()
    {
        $table_data = [];
        $total_data_size = $total_data_free = 0;
          Severity: Minor
          Found in acp/dbtool_module.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language