File jquery.ui.dialog.js
has 695 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*!
* jQuery UI Dialog 1.8.21
*
* Copyright 2012, AUTHORS.txt (http://jqueryui.com/about)
* Dual licensed under the MIT or GPL Version 2 licenses.
Function _create
has 97 lines of code (exceeds 25 allowed). Consider refactoring. Open
_create: function() {
this.originalTitle = this.element.attr('title');
// #5742 - .attr() might return a DOMElement
if ( typeof this.originalTitle !== "string" ) {
this.originalTitle = "";
Function _setOption
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
_setOption: function(key, value){
var self = this,
uiDialog = self.uiDialog;
switch (key) {
Function _createButtons
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
_createButtons: function(buttons) {
var self = this,
hasButtons = false,
uiDialogButtonPane = $('<div></div>')
.addClass(
Function _makeResizable
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
_makeResizable: function(handles) {
handles = (handles === undefined ? this.options.resizable : handles);
var self = this,
options = self.options,
// .ui-resizable has position: relative defined in the stylesheet
Function _size
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
_size: function() {
/* If the user has resized the dialog, the .ui-dialog and .ui-dialog-content
* divs will both have width and height set, so we need to reset them
*/
var options = this.options,
Function _position
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
_position: function(position) {
var myAt = [],
offset = [0, 0],
isVisible;
Function close
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
close: function(event) {
var self = this,
maxZ, thisZ;
if (false === self._trigger('beforeClose', event)) {
Function open
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
open: function() {
if (this._isOpen) { return; }
var self = this,
options = self.options,
Function create
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
create: function(dialog) {
if (this.instances.length === 0) {
// prevent use of anchors and inputs
// we use a setTimeout in case the overlay is created from an
// event that we're going to be cancelling (see #2804)
Function _makeDraggable
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
_makeDraggable: function() {
var self = this,
options = self.options,
doc = $(document),
heightBeforeDrag;
Similar blocks of code found in 2 locations. Consider refactoring. Open
(function( $, undefined ) {
var uiDialogClasses =
'ui-dialog ' +
'ui-widget ' +
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 6680.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76