ianheggie/cruisecontrol.rb

File jquery.ui.draggable.js has 588 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*!
 * jQuery UI Draggable 1.8.21
 *
 * Copyright 2012, AUTHORS.txt (http://jqueryui.com/about)
 * Dual licensed under the MIT or GPL Version 2 licenses.

Consider simplifying this complex logical expression.

Open

            if(!((l-d < x1 && x1 < r+d && t-d < y1 && y1 < b+d) || (l-d < x1 && x1 < r+d && t-d < y2 && y2 < b+d) || (l-d < x2 && x2 < r+d && t-d < y1 && y1 < b+d) || (l-d < x2 && x2 < r+d && t-d < y2 && y2 < b+d))) {
                if(inst.snapElements[i].snapping) (inst.options.snap.release && inst.options.snap.release.call(inst.element, event, $.extend(inst._uiHash(), { snapItem: inst.snapElements[i].item })));
                inst.snapElements[i].snapping = false;
                continue;
            }

Consider simplifying this complex logical expression.

Open

        if(!(/^(document|window|parent)$/).test(o.containment) && o.containment.constructor != Array) {
                var c = $(o.containment);
            var ce = c[0]; if(!ce) return;
            var co = c.offset();
            var over = ($(ce).css("overflow") != 'hidden');

Function drag has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    drag: function(event, ui) {

        var inst = $(this).data("draggable"), self = this;

        var checkPos = function(o) {

Function _generatePosition has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _generatePosition: function(event) {

        var o = this.options, scroll = this.cssPosition == 'absolute' && !(this.scrollParent[0] != document && $.ui.contains(this.scrollParent[0], this.offsetParent[0])) ? this.offsetParent : this.scrollParent, scrollIsRootNode = (/(html|body)/i).test(scroll[0].tagName);
        var pageX = event.pageX;
        var pageY = event.pageY;

Function _mouseStart has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _mouseStart: function(event) {

        var o = this.options;

        //Create and append the visible helper

Function drag has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    drag: function(event, ui) {

        var inst = $(this).data("draggable"), o = inst.options;
        var d = o.snapTolerance;

Function drag has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    drag: function(event, ui) {

        var i = $(this).data("draggable"), o = i.options, scrolled = false;

        if(i.scrollParent[0] != document && i.scrollParent[0].tagName != 'HTML') {

Function _mouseStop has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _mouseStop: function(event) {

        //If we are using droppables, inform the manager about the drop
        var dropped = false;
        if ($.ui.ddmanager && !this.options.dropBehaviour)

Consider simplifying this complex logical expression.

Open

        if((this.options.revert == "invalid" && !dropped) || (this.options.revert == "valid" && dropped) || this.options.revert === true || ($.isFunction(this.options.revert) && this.options.revert.call(this.element, dropped))) {
            var self = this;
            $(this.helper).animate(this.originalPosition, parseInt(this.options.revertDuration, 10), function() {
                if(self._trigger("stop", event) !== false) {
                    self._clear();

Consider simplifying this complex logical expression.

Open

            if(!inst.snapElements[i].snapping && (ts || bs || ls || rs || first))
                (inst.options.snap.snap && inst.options.snap.snap.call(inst.element, event, $.extend(inst._uiHash(), { snapItem: inst.snapElements[i].item })));

Similar blocks of code found in 2 locations. Consider refactoring.

Open

(function( $, undefined ) {

$.widget("ui.draggable", $.ui.mouse, {
    widgetEventPrefix: "drag",
    options: {

• Read up
  Read up