Showing 5 of 11 total issues
Method check_job
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def check_job(id, headers = {}, callback_and_args = [], specify_res_id = true)
flag = success?(id, headers)
return if "DELETE" == @res.body["method"]
if flag == true
if specify_res_id == true
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method patch_l7route
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def patch_l7route(lb_id, config_id, id, data, headers = {})
Method initialize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(client, method, resource, parameters, headers)
Method validate_absence!
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def validate_absence!(attributes, action)
if action
attributes.each do |name, value|
next unless !valid_attributes[name] || !valid_attributes[name][action]
raise(UnnecessaryAttribute, "`#{name}` is unnecessary in #{action} action")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method valid_attribute?
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def valid_attribute?(value, valid_type)
case valid_type
when Array
valid_type.any? { |t| valid_attribute?(value, t) }
when Regexp
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"