idlesign/django-siteblocks

View on GitHub

Showing 1 of 3 total issues

Function get_contents_static has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    def get_contents_static(self, block_alias: str, context: Context) -> str:
        """Returns contents of a static block."""

        if 'request' not in context:
            # No use in further actions as we won't ever know current URL.
Severity: Minor
Found in siteblocks/siteblocksapp.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language