Sign upLogin

idlesign/django-sitegate

View on GitHub
Star

Showing 13 of 13 total issues

Function construct_user has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def construct_user(self, user_data: UserData) -> Optional['User']:
        """Spawns a new user instance. Return None on failure.

        :param user_data:
Severity: Minor
Found in sitegate/signin_flows/remotes/base.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function remote_auth has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def remote_auth(request: HttpRequest, alias: str) -> HttpResponse:
    """Performs an authorization using data from a remote.
    
    For a user which is anonymous or not yet linked to target remote.
Severity: Minor
Found in sitegate/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def save(self, force_insert=False, force_update=False, **kwargs):

        if self.code == '':
            while True:
                self.code = self.generate_code()
Severity: Minor
Found in sitegate/models.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def render(self, context: Context) -> str:
        try:
            forms = context['request'].sitegate[f'{self.type}_forms']

            if self.flow_name is None:
Severity: Minor
Found in sitegate/templatetags/sitegate.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function auth_finish has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def auth_finish(
Severity: Minor
Found in sitegate/signin_flows/remotes/base.py - About 45 mins to fix

    Function handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def handle(self, func: Callable, args_func: tuple, kwargs_func: dict, args_dec: tuple, kwargs_dec: dict):
    Severity: Minor
    Found in sitegate/decorators.py - About 35 mins to fix

      Function handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def handle(self, func, args_func, kwargs_func, args_dec, kwargs_dec):
      Severity: Minor
      Found in sitegate/utils.py - About 35 mins to fix

        Function handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def handle(self, func: Callable, args_func: tuple, kwargs_func: dict, args_dec: tuple, kwargs_dec: dict):
        Severity: Minor
        Found in sitegate/decorators.py - About 35 mins to fix

          Function handle_form_valid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def handle_form_valid(self, request: HttpRequest, form: ModelForm) -> Optional[HttpResponse]:
        flow_name = self.get_flow_name()

        if not self.get_arg_or_attr('activate_user'):
            form.instance.is_active = False
          Severity: Minor
          Found in sitegate/signup_flows/base.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return remote.redirect()
          Severity: Major
          Found in sitegate/views.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return remote.auth_finish(
            Severity: Major
            Found in sitegate/views.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return remote.auth_continue(request)
              Severity: Major
              Found in sitegate/views.py - About 30 mins to fix

                Function remote_auth_start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def remote_auth_start(request: HttpRequest, alias: str) -> HttpResponse:
    """Performs a redirect to another service for remote auth.

    :param request:
    :param alias: remote service alias
                Severity: Minor
                Found in sitegate/views.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language