Showing 5 of 7 total issues
Method xml_node_to_hash has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
Open
def xml_node_to_hash(node)
if node.element?
if node.children? || node.attributes?
result_hash = {}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method request has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
def request(method, path, params = {}, options = {})
if !METHODS.include?(method)
raise ArgumentError, "unkown http method: #{method}"
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method xml_node_to_hash has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def xml_node_to_hash(node)
if node.element?
if node.children? || node.attributes?
result_hash = {}
Avoid deeply nested control flow statements. Open
Open
if result_hash[child.name.underscore.to_sym].is_a?(Object::Array)
result_hash[child.name.underscore.to_sym] << result
else
result_hash[child.name.underscore.to_sym] = [result_hash[child.name.underscore.to_sym]] << result
endAvoid deeply nested control flow statements. Open
Open
elsif result.present?
result_hash[child.name.underscore.to_sym] = result