ike18t/spotify_jukebox

View on GitHub

Showing 5 of 9 total issues

Method get_callbacks has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_callbacks
    $session_callbacks ||= {
      log_message: proc do |_session, message|
        $logger.debug('session (log message)') { message }
      end,
Severity: Minor
Found in app/spotify_wrapper.rb - About 1 hr to fix

    Method start! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def start!
        current_user = nil
        loop do
          enabled_users = UserService.get_enabled_users
          enabled_playlists = PlaylistService.get_enabled_playlists
    Severity: Minor
    Found in app/jukebox_player.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method stream has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def stream(frame_format, frames, num_frames)
        synchronize do
          if buffers_processed > 0
            FFI::MemoryPointer.new(OpenAL::Buffer, buffers_processed) do |ptr|
              OpenAL.source_unqueue_buffers(@source, ptr.count, ptr)
    Severity: Minor
    Found in monkey_patches/plaything.rb - About 1 hr to fix

      Method stream has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def stream(frame_format, frames, num_frames)
          synchronize do
            if buffers_processed > 0
              FFI::MemoryPointer.new(OpenAL::Buffer, buffers_processed) do |ptr|
                OpenAL.source_unqueue_buffers(@source, ptr.count, ptr)
      Severity: Minor
      Found in monkey_patches/plaything.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method autoload_all has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      def autoload_all(path)
        Dir.glob("#{path}**/*.rb").each do |file|
          File.open(file, 'r') do |infile|
            while (line = infile.gets)
              match = line.match(/^(class|module)\s([A-Z]\w+)/)
      Severity: Minor
      Found in configure.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language