Sign upLogin

ilkkao/mas

View on GitHub
Star
client/app/models/Message.js

Summary

Maintainability
D
1 day
Test Coverage

Function _parseLinks has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  _parseLinks(text) {
    const imgSuffixes = ['png', 'jpg', 'jpeg', 'gif', 'webp'];
    const media = [];
    let body = '';
Severity: Minor
Found in client/app/models/Message.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

MessageModel has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class MessageModel {
  gid = 0;
  @observable body = null;
  cat = null;
  ts = null;
Severity: Minor
Found in client/app/models/Message.js - About 3 hrs to fix

    File Message.js has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { computed, observable } from 'mobx';
import marked from 'marked';
import emojione from 'emojione';
import moment from 'moment';
import URI from 'urijs';
    Severity: Minor
    Found in client/app/models/Message.js - About 2 hrs to fix

      Function _parseLinks has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _parseLinks(text) {
    const imgSuffixes = ['png', 'jpg', 'jpeg', 'gif', 'webp'];
    const media = [];
    let body = '';
      Severity: Minor
      Found in client/app/models/Message.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                    if (re) {
              inSeconds = parseInt(re[1] || 0) * 3600 + parseInt(re[2] || 0) * 60 + parseInt(re[3] || 0);
            }
        Severity: Major
        Found in client/app/models/Message.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            @computed
  get updatedDateLong() {
    const updatedTs = this.updatedTs;

    return updatedTs ? `at ${moment.unix(updatedTs).format('dddd, MMMM D HH:mm')}` : '';
          Severity: Major
          Found in client/app/models/Message.js and 1 other location - About 1 hr to fix
          client/app/models/Message.js on lines 56..61

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            @computed
  get updatedDate() {
    const updatedTs = this.updatedTs;

    return updatedTs ? `at ${moment.unix(updatedTs).format('MMM Do HH:mm')}` : '';
          Severity: Major
          Found in client/app/models/Message.js and 1 other location - About 1 hr to fix
          client/app/models/Message.js on lines 63..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status