Sign upLogin

ilkkao/mas

View on GitHub
Star
server/lib/passport.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function setup has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setup() {
  if (conf.get('googleauth:enabled')) {
    const GoogleStrategy = require('passport-google-oauth').OAuth2Strategy;
    const jwt = require('jwt-simple');
Severity: Major
Found in server/lib/passport.js - About 2 hrs to fix

    Function authLocal has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    async function authLocal(username, password, done) {
  if (!username) {
    return;
  }
    Severity: Minor
    Found in server/lib/passport.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function authLocal has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function authLocal(username, password, done) {
  if (!username) {
    return;
  }
    Severity: Minor
    Found in server/lib/passport.js - About 1 hr to fix

      Function authExt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function authExt(openidId, oauthId, profile, done) {
  let user = null;

  if (oauthId) {
    user = await User.findFirst({ extAuthId: oauthId });
      Severity: Minor
      Found in server/lib/passport.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status