Sign upLogin

ilkkao/mas

View on GitHub
Star
server/lib/userIntroducer.js

Summary

Maintainability
C
1 day
Test Coverage

Function introduceUsers has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

async function introduceUsers(user, userGIds, session, socket) {
  if (session) {
    // If no session is given, force broadcast userGids without remembering them
    session.knownUserGIds = session.knownUserGIds || {};
  }
Severity: Minor
Found in server/lib/userIntroducer.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function introduceUsers has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function introduceUsers(user, userGIds, session, socket) {
  if (session) {
    // If no session is given, force broadcast userGids without remembering them
    session.knownUserGIds = session.knownUserGIds || {};
  }
Severity: Major
Found in server/lib/userIntroducer.js - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

              for (const network of networks) {
            const currentNick = await nicksService.getNick(foundUser.gId, network);

            // Fallback to default nick. This solves the situation where the user joins
            // a new IRC network during the session. In that case his own userGId is in
    Severity: Major
    Found in server/lib/userIntroducer.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                for (const network of networks) {
            entry.nick[network] = 'UNKNOWN';
          }
      Severity: Major
      Found in server/lib/userIntroducer.js - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status