Sign upLogin

ilkkao/mas

View on GitHub
Star
server/models/user.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function setters has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static get setters() {
    return {
      name: function name(realName) {
        if (!realName || realName.length < 6) {
          return { valid: false, error: 'Please enter at least 6 characters.' };
Severity: Minor
Found in server/models/user.js - About 1 hr to fix

    Function setters has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      static get setters() {
    return {
      name: function name(realName) {
        if (!realName || realName.length < 6) {
          return { valid: false, error: 'Please enter at least 6 characters.' };
    Severity: Minor
    Found in server/models/user.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static async create(props, { skipSetters = false } = {}) {
    trimWhiteSpace(props);

    if (!skipSetters) {
      const passwordValidation = validatePassword(props.password);
    Severity: Minor
    Found in server/models/user.js - About 1 hr to fix

      Function create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        static async create(props, { skipSetters = false } = {}) {
    trimWhiteSpace(props);

    if (!skipSetters) {
      const passwordValidation = validatePassword(props.password);
      Severity: Minor
      Found in server/models/user.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in server/models/user.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return { valid: true, value: nickName };
        Severity: Major
        Found in server/models/user.js - About 30 mins to fix

          Function verifyPassword has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            async verifyPassword(password) {
    const encryptedPassword = this.get('password');
    const encryptionMethod = this.get('passwordType');

    if (!encryptedPassword) {
          Severity: Minor
          Found in server/models/user.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            get gIdString() {
    if (!this._gIdString) {
      this._gIdString = this.gId.toString();
    }
          Severity: Minor
          Found in server/models/user.js and 1 other location - About 45 mins to fix
          server/models/conversationMember.js on lines 34..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status