imaginerio/imaginerioNext

View on GitHub
providers/ImageContext.js

Summary

Maintainability
D
1 day
Test Coverage

Function reducer has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

function reducer(state, [type, payload]) {
  switch (type) {
    case 'QUERY':
      return {
        ...state,
Severity: Major
Found in providers/ImageContext.js - About 4 hrs to fix

    File ImageContext.js has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { createContext, useContext, useEffect, useReducer } from 'react';
    import PropTypes from 'prop-types';
    import { orderBy, countBy } from 'lodash';
    import unaccent from '../utils/unaccent';
    
    
    Severity: Minor
    Found in providers/ImageContext.js - About 2 hrs to fix

      Function search has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      const search = ({ query, dates, sort, direction, allImages, collection, mapBounds }) => {
        if (!allImages) return [];
        let items = allImages;
        if (query) items = items.filter(item => textSearch({ item, query }));
        if (collection && collection !== 'all')
      Severity: Minor
      Found in providers/ImageContext.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            } else if (unaccent(item.source.value).match(regex)) return true;
      Severity: Major
      Found in providers/ImageContext.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                if (item.depicts.value.some(d => unaccent(d).match(regex))) return true;
        Severity: Major
        Found in providers/ImageContext.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                } else if (unaccent(item.depicts).match(regex)) return true;
          Severity: Major
          Found in providers/ImageContext.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    if (item.source.value.some(d => unaccent(d).match(regex))) return true;
            Severity: Major
            Found in providers/ImageContext.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  if (item.date && item.date.toString().match(regex)) return true;
              Severity: Major
              Found in providers/ImageContext.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        if (unaccent(item.depicts.value).match(regex)) return true;
                Severity: Major
                Found in providers/ImageContext.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return false;
                  Severity: Major
                  Found in providers/ImageContext.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (item.creator) {
                          if (Array.isArray(item.creator.value)) {
                            if (item.creator.value.some(d => unaccent(d).match(regex))) return true;
                          } else if (unaccent(item.creator.value).match(regex)) return true;
                        }
                    Severity: Major
                    Found in providers/ImageContext.js and 1 other location - About 3 hrs to fix
                    providers/ImageContext.js on lines 18..22

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 101.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (item.source) {
                          if (Array.isArray(item.source.value)) {
                            if (item.source.value.some(d => unaccent(d).match(regex))) return true;
                          } else if (unaccent(item.source.value).match(regex)) return true;
                        }
                    Severity: Major
                    Found in providers/ImageContext.js and 1 other location - About 3 hrs to fix
                    providers/ImageContext.js on lines 11..15

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 101.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status