inadarei/uber.client.js

View on GitHub

Showing 12 of 18 total issues

Function uberizeJSON has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

function uberizeJSON(json) {
  var prop, el;

  for (prop in json) {
    if (json.hasOwnProperty(prop)) {
Severity: Minor
Found in lib/message.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findAllKeyDataEntities has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

function findAllKeyDataEntities(json, key, isChildStep) {
  var prop, subprop;
  var results = [];

  // The top-level element should be analyzed only at the top of the recursion, otherwise
Severity: Minor
Found in lib/util.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function uberizeJSON has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function uberizeJSON(json) {
  var prop, el;

  for (prop in json) {
    if (json.hasOwnProperty(prop)) {
Severity: Minor
Found in lib/message.js - About 1 hr to fix

    Function findQueryMatches has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function findQueryMatches(json, key, pattern) {
      if (!(pattern instanceof RegExp)) {
        pattern = new RegExp(pattern, "i");
      }
      var unfilteredJsonObjects = findAllKeyDataEntities(json, key);
    Severity: Minor
    Found in lib/util.js - About 1 hr to fix

      Function Data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function Data(msg) {
        var initJSONData;
        // Preventing closure-related hell with "this"
        var self = this;
      
      
      Severity: Minor
      Found in lib/dataElement.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Data has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function Data(msg) {
        var initJSONData;
        // Preventing closure-related hell with "this"
        var self = this;
      
      
      Severity: Minor
      Found in lib/dataElement.js - About 1 hr to fix

        Function new has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.new = function(message, callback) {
          var uberMsg = new Message(message);
          if (uberMsg.rawFormat() === "unknown") {
            var err = new Error("Couldn't initialize an UBER message. Provided initialization string/object was " +
                                "neither a valid XML or JSON: " + message);
        Severity: Minor
        Found in lib/message.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                    if (json[prop].hasOwnProperty(el)) {
                      // rels in UBER XML are space-sep, in JSON: comma-sep.
                      if (el === 'rel') {
                        json[prop][el] = json[prop][el].split(/\s+?/im);
                      }
          Severity: Major
          Found in lib/message.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      for (var i =0; i<next.length; i++) {
                        results[results.length] = next[i];
                      }
            Severity: Major
            Found in lib/util.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                        if (subprop === key) {
                          // We are interested in the json object surrounding the the key (e.g. "rel"),
                          // not the one "rel" points to.
                          results[results.length] = json[prop];
                        }
              Severity: Major
              Found in lib/util.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                          if (json[prop].hasOwnProperty(dataprop)) {
                            if ((typeof json[prop][dataprop] === 'string') || (typeof json[prop][dataprop] === 'number')) {
                              valuecache = json[prop][dataprop];
                              json[prop][dataprop] = {};
                              json[prop][dataprop].value = valuecache;
                Severity: Major
                Found in lib/message.js - About 45 mins to fix

                  Function DataArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function DataArray(msg) {
                    var initJSONData;
                    // Preventing closure-related hell with "this"
                    var self = this;
                  
                  
                  Severity: Minor
                  Found in lib/dataArray.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language