Sign upLogin

inadarei/uber.client.js

View on GitHub
Star
lib/message.js

Summary

Maintainability
D
1 day
Test Coverage

Function uberizeJSON has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

function uberizeJSON(json) {
  var prop, el;

  for (prop in json) {
    if (json.hasOwnProperty(prop)) {
Severity: Minor
Found in lib/message.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function uberizeJSON has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function uberizeJSON(json) {
  var prop, el;

  for (prop in json) {
    if (json.hasOwnProperty(prop)) {
Severity: Minor
Found in lib/message.js - About 1 hr to fix

    Function new has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.new = function(message, callback) {
  var uberMsg = new Message(message);
  if (uberMsg.rawFormat() === "unknown") {
    var err = new Error("Couldn't initialize an UBER message. Provided initialization string/object was " +
                        "neither a valid XML or JSON: " + message);
    Severity: Minor
    Found in lib/message.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                if (json[prop].hasOwnProperty(dataprop)) {
            if ((typeof json[prop][dataprop] === 'string') || (typeof json[prop][dataprop] === 'number')) {
              valuecache = json[prop][dataprop];
              json[prop][dataprop] = {};
              json[prop][dataprop].value = valuecache;
      Severity: Major
      Found in lib/message.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if (json[prop].hasOwnProperty(el)) {
            // rels in UBER XML are space-sep, in JSON: comma-sep.
            if (el === 'rel') {
              json[prop][el] = json[prop][el].split(/\s+?/im);
            }
        Severity: Major
        Found in lib/message.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (typeof jsonMessage.uber.data === 'undefined' ) {
          dataEl = [];
        } else { dataEl = jsonMessage.uber.data; }
          Severity: Minor
          Found in lib/message.js and 1 other location - About 40 mins to fix
          lib/message.js on lines 64..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (typeof jsonMessage.uber.error === 'undefined' ) {
          errorEl = [];
        } else { errorEl = jsonMessage.uber.error; }
          Severity: Minor
          Found in lib/message.js and 1 other location - About 40 mins to fix
          lib/message.js on lines 61..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status