inadarei/uber.client.js

View on GitHub
lib/util.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function findAllKeyDataEntities has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

function findAllKeyDataEntities(json, key, isChildStep) {
  var prop, subprop;
  var results = [];

  // The top-level element should be analyzed only at the top of the recursion, otherwise
Severity: Minor
Found in lib/util.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findQueryMatches has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function findQueryMatches(json, key, pattern) {
  if (!(pattern instanceof RegExp)) {
    pattern = new RegExp(pattern, "i");
  }
  var unfilteredJsonObjects = findAllKeyDataEntities(json, key);
Severity: Minor
Found in lib/util.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

              if (subprop === key) {
                // We are interested in the json object surrounding the the key (e.g. "rel"),
                // not the one "rel" points to.
                results[results.length] = json[prop];
              }
    Severity: Major
    Found in lib/util.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                for (var i =0; i<next.length; i++) {
                  results[results.length] = next[i];
                }
      Severity: Major
      Found in lib/util.js - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status