Showing 3 of 3 total issues
Consider simplifying this complex logical expression. Open
Open
if not 'review' in payload \
or not 'action' in payload \
or payload['action'] != 'submitted' \
or not 'user' in payload['review'] \
or not 'state' in payload['review'] \
Function jira_issue_transition_update
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def jira_issue_transition_update():
if not helper.check_github_ip(src_ip=request.access_route[0]):
raise NotAcceptable('Github IP whitelist check failed! IP: {}'.format(request.access_route[0]))
if not helper.check_github_pull_request_payload(payload=request.json):
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function save_pull_request_review
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def save_pull_request_review(self, issue_id, pr_id, issue_owner_username, reviewer_username, action):