indentlabs/notebook

View on GitHub
app/javascript/components/PageLookupSidebar.js

Summary

Maintainability
F
5 days
Test Coverage

Function pageData has 126 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  pageData() {
    if (this.state.show_data) {
      return (
        <div
          role="presentation"
Severity: Major
Found in app/javascript/components/PageLookupSidebar.js - About 5 hrs to fix

    File PageLookupSidebar.js has 334 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
      Usage:
      <%= react_component("PageLookupSidebar", {document_id: @document.id}) %>
    */
    
    
    Severity: Minor
    Found in app/javascript/components/PageLookupSidebar.js - About 4 hrs to fix

      Function fieldData has 98 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        fieldData(field) {
          switch (field.type) {
            case "name":
            case "text_area":
              // console.log(field.value);
      Severity: Major
      Found in app/javascript/components/PageLookupSidebar.js - About 3 hrs to fix

        Function loadPage has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async loadPage(page_type, page_id) {
            this.setDrawerVisible(true);
            this.setState({
              show_data:     false,
              category_open: {}
        Severity: Minor
        Found in app/javascript/components/PageLookupSidebar.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      <a href={this.content_page_edit_path(this.state.page_type, this.state.page_id)}>
                        <ListItem button>
                          <i className={"green-text material-icons left"}>
                            { this.classIcon(this.state.page_type) }
                          </i>
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js and 1 other location - About 4 hrs to fix
          app/javascript/components/PageLookupSidebar.js on lines 273..280

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 127.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      <a href={this.content_page_view_path(this.state.page_type, this.state.page_id)}>
                        <ListItem button>
                          <i className={"blue-text material-icons left"}>
                            { this.classIcon(this.state.page_type) }
                          </i>
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js and 1 other location - About 4 hrs to fix
          app/javascript/components/PageLookupSidebar.js on lines 281..288

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 127.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                        <div className="spinner-layer spinner-green">
                          <div className="circle-clipper left">
                            <div className="circle"></div>
                          </div><div className="gap-patch">
                            <div className="circle"></div>
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
          app/javascript/components/PageLookupSidebar.js on lines 320..328
          app/javascript/components/PageLookupSidebar.js on lines 330..338
          app/javascript/components/PageLookupSidebar.js on lines 340..348

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                        <div className="spinner-layer spinner-blue">
                          <div className="circle-clipper left">
                            <div className="circle"></div>
                          </div><div className="gap-patch">
                            <div className="circle"></div>
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
          app/javascript/components/PageLookupSidebar.js on lines 330..338
          app/javascript/components/PageLookupSidebar.js on lines 340..348
          app/javascript/components/PageLookupSidebar.js on lines 350..358

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                        <div className="spinner-layer spinner-red">
                          <div className="circle-clipper left">
                            <div className="circle"></div>
                          </div><div className="gap-patch">
                            <div className="circle"></div>
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
          app/javascript/components/PageLookupSidebar.js on lines 320..328
          app/javascript/components/PageLookupSidebar.js on lines 340..348
          app/javascript/components/PageLookupSidebar.js on lines 350..358

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                        <div className="spinner-layer spinner-yellow">
                          <div className="circle-clipper left">
                            <div className="circle"></div>
                          </div><div className="gap-patch">
                            <div className="circle"></div>
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js and 3 other locations - About 4 hrs to fix
          app/javascript/components/PageLookupSidebar.js on lines 320..328
          app/javascript/components/PageLookupSidebar.js on lines 330..338
          app/javascript/components/PageLookupSidebar.js on lines 350..358

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                <Drawer anchor='right'
                        open={this.state['open']}
                        onClose={() => this.setDrawerVisible(false)}
                >
                  {this.pageData()}
          Severity: Major
          Found in app/javascript/components/PageLookupSidebar.js and 1 other location - About 1 hr to fix
          app/javascript/components/QuickActionsSidebar.js on lines 192..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status