Sign upLogin

indutny/elliptic

View on GitHub
Star
lib/elliptic/curve/mont.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function Point has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function Point(curve, x, z) {
  Base.BasePoint.call(this, curve, 'projective');
  if (x === null && z === null) {
    this.x = this.curve.one;
    this.z = this.curve.zero;
Severity: Minor
Found in lib/elliptic/curve/mont.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

XXX found
Open

  // XXX This code assumes that zero is always zero in red
Severity: Minor
Found in lib/elliptic/curve/mont.js by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Point.prototype.inspect = function inspect() {
  if (this.isInfinity())
    return '<EC Point Infinity>';
  return '<EC Point x: ' + this.x.fromRed().toString(16, 2) +
      ' z: ' + this.z.fromRed().toString(16, 2) + '>';
Severity: Major
Found in lib/elliptic/curve/mont.js and 1 other location - About 3 hrs to fix
lib/elliptic/curve/short.js on lines 354..359

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    if (!this.x.red)
      this.x = this.x.toRed(this.curve.red);
Severity: Major
Found in lib/elliptic/curve/mont.js and 9 other locations - About 30 mins to fix
lib/elliptic/curve/edwards.js on lines 127..128
lib/elliptic/curve/edwards.js on lines 129..130
lib/elliptic/curve/edwards.js on lines 131..132
lib/elliptic/curve/mont.js on lines 40..41
lib/elliptic/curve/short.js on lines 265..266
lib/elliptic/curve/short.js on lines 267..268
lib/elliptic/curve/short.js on lines 501..502
lib/elliptic/curve/short.js on lines 503..504
lib/elliptic/curve/short.js on lines 505..506

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

    if (!this.z.red)
      this.z = this.z.toRed(this.curve.red);
Severity: Major
Found in lib/elliptic/curve/mont.js and 9 other locations - About 30 mins to fix
lib/elliptic/curve/edwards.js on lines 127..128
lib/elliptic/curve/edwards.js on lines 129..130
lib/elliptic/curve/edwards.js on lines 131..132
lib/elliptic/curve/mont.js on lines 38..39
lib/elliptic/curve/short.js on lines 265..266
lib/elliptic/curve/short.js on lines 267..268
lib/elliptic/curve/short.js on lines 501..502
lib/elliptic/curve/short.js on lines 503..504
lib/elliptic/curve/short.js on lines 505..506

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Parsing error: Invalid ecmaVersion.
Open

'use strict';
Severity: Minor
Found in lib/elliptic/curve/mont.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status