indutny/elliptic

View on GitHub
lib/elliptic/curve/short.js

Summary

Maintainability
F
6 days
Test Coverage

File short.js has 698 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var utils = require('../utils');
var BN = require('bn.js');
var inherits = require('inherits');
Severity: Major
Found in lib/elliptic/curve/short.js - About 1 day to fix

    Function _getEndoBasis has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ShortCurve.prototype._getEndoBasis = function _getEndoBasis(lambda) {
      // aprxSqrt >= sqrt(this.n)
      var aprxSqrt = this.n.ushrn(Math.floor(this.n.bitLength() / 2));
    
      // 3.74
    Severity: Major
    Found in lib/elliptic/curve/short.js - About 2 hrs to fix

      Function _getEndomorphism has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      ShortCurve.prototype._getEndomorphism = function _getEndomorphism(conf) {
        // No efficient endomorphism
        if (!this.zeroA || !this.g || !this.n || this.p.modn(3) !== 1)
          return;
      
      
      Severity: Minor
      Found in lib/elliptic/curve/short.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _getEndomorphism has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ShortCurve.prototype._getEndomorphism = function _getEndomorphism(conf) {
        // No efficient endomorphism
        if (!this.zeroA || !this.g || !this.n || this.p.modn(3) !== 1)
          return;
      
      
      Severity: Minor
      Found in lib/elliptic/curve/short.js - About 1 hr to fix

        Function dblp has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        JPoint.prototype.dblp = function dblp(pow) {
          if (pow === 0)
            return this;
          if (this.isInfinity())
            return this;
        Severity: Minor
        Found in lib/elliptic/curve/short.js - About 1 hr to fix

          Function _threeDbl has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          JPoint.prototype._threeDbl = function _threeDbl() {
            var nx;
            var ny;
            var nz;
            // Z = 1
          Severity: Minor
          Found in lib/elliptic/curve/short.js - About 1 hr to fix

            Function _zeroDbl has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            JPoint.prototype._zeroDbl = function _zeroDbl() {
              var nx;
              var ny;
              var nz;
              // Z = 1
            Severity: Minor
            Found in lib/elliptic/curve/short.js - About 1 hr to fix

              Function trpl has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              JPoint.prototype.trpl = function trpl() {
                if (!this.curve.zeroA)
                  return this.dbl().add(this);
              
                // hyperelliptic.org/EFD/g1p/auto-shortw-jacobian-0.html#tripling-tpl-2007-bl
              Severity: Minor
              Found in lib/elliptic/curve/short.js - About 1 hr to fix

                Function dblp has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                JPoint.prototype.dblp = function dblp(pow) {
                  if (pow === 0)
                    return this;
                  if (this.isInfinity())
                    return this;
                Severity: Minor
                Found in lib/elliptic/curve/short.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _getEndoBasis has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                ShortCurve.prototype._getEndoBasis = function _getEndoBasis(lambda) {
                  // aprxSqrt >= sqrt(this.n)
                  var aprxSqrt = this.n.ushrn(Math.floor(this.n.bitLength() / 2));
                
                  // 3.74
                Severity: Minor
                Found in lib/elliptic/curve/short.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function Point has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function Point(curve, x, y, isRed) {
                  Base.BasePoint.call(this, curve, 'affine');
                  if (x === null && y === null) {
                    this.x = null;
                    this.y = null;
                Severity: Minor
                Found in lib/elliptic/curve/short.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this function.
                Open

                  return this.curve.jpoint(nx, ny, nz);
                Severity: Major
                Found in lib/elliptic/curve/short.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return this.curve.jpoint(jx, jyd.redMul(tinv), jz);
                  Severity: Major
                  Found in lib/elliptic/curve/short.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                      return this.curve.jpoint(nx, ny, nz);
                    Severity: Major
                    Found in lib/elliptic/curve/short.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return this.curve.point(null, null);
                      Severity: Major
                      Found in lib/elliptic/curve/short.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                          return this.curve.point(nx, ny);
                        Severity: Major
                        Found in lib/elliptic/curve/short.js - About 30 mins to fix

                          Function _endoWnafMulAdd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              function _endoWnafMulAdd(points, coeffs, jacobianResult) {
                                var npoints = this._endoWnafT1;
                                var ncoeffs = this._endoWnafT2;
                                for (var i = 0; i < points.length; i++) {
                                  var split = this._endoSplit(coeffs[i]);
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function eqXToP has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          JPoint.prototype.eqXToP = function eqXToP(x) {
                            var zs = this.z.redSqr();
                            var rx = x.toRed(this.curve.red).redMul(zs);
                            if (this.x.cmp(rx) === 0)
                              return true;
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          Point.prototype.add = function add(p) {
                            // O + P = P
                            if (this.inf)
                              return p;
                          
                          
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          XXX found
                          Open

                            // XXX Is there any way to tell if the number is odd without converting it
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js by fixme

                          XXX found
                          Open

                            // XXX This code assumes that zero is always zero in red
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js by fixme

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          Point.prototype.inspect = function inspect() {
                            if (this.isInfinity())
                              return '<EC Point Infinity>';
                            return '<EC Point x: ' + this.x.fromRed().toString(16, 2) +
                                ' y: ' + this.y.fromRed().toString(16, 2) + '>';
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 3 hrs to fix
                          lib/elliptic/curve/mont.js on lines 70..75

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 95.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                            for (;;) {
                              xc.iadd(this.curve.n);
                              if (xc.cmp(this.curve.p) >= 0)
                                return false;
                          
                          
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 2 hrs to fix
                          lib/elliptic/curve/edwards.js on lines 422..430

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 85.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                            if (h.cmpn(0) === 0) {
                              if (r.cmpn(0) !== 0)
                                return this.curve.jpoint(null, null, null);
                              else
                                return this.dbl();
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 1 hr to fix
                          lib/elliptic/curve/short.js on lines 551..556

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                            if (h.cmpn(0) === 0) {
                              if (r.cmpn(0) !== 0)
                                return this.curve.jpoint(null, null, null);
                              else
                                return this.dbl();
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 1 hr to fix
                          lib/elliptic/curve/short.js on lines 587..592

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              doubles: this.precomputed.doubles && {
                                step: this.precomputed.doubles.step,
                                points: this.precomputed.doubles.points.slice(1),
                              },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 1 hr to fix
                          lib/elliptic/curve/short.js on lines 321..324

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 60.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              naf: this.precomputed.naf && {
                                wnd: this.precomputed.naf.wnd,
                                points: this.precomputed.naf.points.slice(1),
                              },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 1 hr to fix
                          lib/elliptic/curve/short.js on lines 317..320

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 60.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              doubles: pre.doubles && {
                                step: pre.doubles.step,
                                points: [ res ].concat(pre.doubles.points.map(obj2point)),
                              },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 1 hr to fix
                          lib/elliptic/curve/short.js on lines 346..349

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              naf: pre.naf && {
                                wnd: pre.naf.wnd,
                                points: [ res ].concat(pre.naf.points.map(obj2point)),
                              },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 1 other location - About 1 hr to fix
                          lib/elliptic/curve/short.js on lines 342..345

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                doubles: pre.doubles && {
                                  step: pre.doubles.step,
                                  points: pre.doubles.points.map(endoMul),
                                },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 3 other locations - About 40 mins to fix
                          lib/elliptic/curve/short.js on lines 299..302
                          lib/elliptic/curve/short.js on lines 469..472
                          lib/elliptic/curve/short.js on lines 473..476

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 48.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                naf: pre.naf && {
                                  wnd: pre.naf.wnd,
                                  points: pre.naf.points.map(negate),
                                },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 3 other locations - About 40 mins to fix
                          lib/elliptic/curve/short.js on lines 299..302
                          lib/elliptic/curve/short.js on lines 303..306
                          lib/elliptic/curve/short.js on lines 473..476

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 48.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                doubles: pre.doubles && {
                                  step: pre.doubles.step,
                                  points: pre.doubles.points.map(negate),
                                },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 3 other locations - About 40 mins to fix
                          lib/elliptic/curve/short.js on lines 299..302
                          lib/elliptic/curve/short.js on lines 303..306
                          lib/elliptic/curve/short.js on lines 469..472

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 48.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                naf: pre.naf && {
                                  wnd: pre.naf.wnd,
                                  points: pre.naf.points.map(endoMul),
                                },
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 3 other locations - About 40 mins to fix
                          lib/elliptic/curve/short.js on lines 303..306
                          lib/elliptic/curve/short.js on lines 469..472
                          lib/elliptic/curve/short.js on lines 473..476

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 48.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 10 locations. Consider refactoring.
                          Open

                            if (!this.z.red)
                              this.z = this.z.toRed(this.curve.red);
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
                          lib/elliptic/curve/edwards.js on lines 127..128
                          lib/elliptic/curve/edwards.js on lines 129..130
                          lib/elliptic/curve/edwards.js on lines 131..132
                          lib/elliptic/curve/mont.js on lines 38..39
                          lib/elliptic/curve/mont.js on lines 40..41
                          lib/elliptic/curve/short.js on lines 265..266
                          lib/elliptic/curve/short.js on lines 267..268
                          lib/elliptic/curve/short.js on lines 501..502
                          lib/elliptic/curve/short.js on lines 503..504

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            return this.y.redMul(pz3).redISub(p.y.redMul(z3)).cmpn(0) === 0;
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js and 1 other location - About 30 mins to fix
                          lib/elliptic/curve/short.js on lines 899..899

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 10 locations. Consider refactoring.
                          Open

                            if (!this.x.red)
                              this.x = this.x.toRed(this.curve.red);
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
                          lib/elliptic/curve/edwards.js on lines 127..128
                          lib/elliptic/curve/edwards.js on lines 129..130
                          lib/elliptic/curve/edwards.js on lines 131..132
                          lib/elliptic/curve/mont.js on lines 38..39
                          lib/elliptic/curve/mont.js on lines 40..41
                          lib/elliptic/curve/short.js on lines 265..266
                          lib/elliptic/curve/short.js on lines 267..268
                          lib/elliptic/curve/short.js on lines 503..504
                          lib/elliptic/curve/short.js on lines 505..506

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 10 locations. Consider refactoring.
                          Open

                            if (!this.y.red)
                              this.y = this.y.toRed(this.curve.red);
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
                          lib/elliptic/curve/edwards.js on lines 127..128
                          lib/elliptic/curve/edwards.js on lines 129..130
                          lib/elliptic/curve/edwards.js on lines 131..132
                          lib/elliptic/curve/mont.js on lines 38..39
                          lib/elliptic/curve/mont.js on lines 40..41
                          lib/elliptic/curve/short.js on lines 265..266
                          lib/elliptic/curve/short.js on lines 267..268
                          lib/elliptic/curve/short.js on lines 501..502
                          lib/elliptic/curve/short.js on lines 505..506

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            if (this.x.redMul(pz2).redISub(p.x.redMul(z2)).cmpn(0) !== 0)
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js and 1 other location - About 30 mins to fix
                          lib/elliptic/curve/short.js on lines 905..905

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 10 locations. Consider refactoring.
                          Open

                              if (!this.x.red)
                                this.x = this.x.toRed(this.curve.red);
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
                          lib/elliptic/curve/edwards.js on lines 127..128
                          lib/elliptic/curve/edwards.js on lines 129..130
                          lib/elliptic/curve/edwards.js on lines 131..132
                          lib/elliptic/curve/mont.js on lines 38..39
                          lib/elliptic/curve/mont.js on lines 40..41
                          lib/elliptic/curve/short.js on lines 267..268
                          lib/elliptic/curve/short.js on lines 501..502
                          lib/elliptic/curve/short.js on lines 503..504
                          lib/elliptic/curve/short.js on lines 505..506

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 10 locations. Consider refactoring.
                          Open

                              if (!this.y.red)
                                this.y = this.y.toRed(this.curve.red);
                          Severity: Major
                          Found in lib/elliptic/curve/short.js and 9 other locations - About 30 mins to fix
                          lib/elliptic/curve/edwards.js on lines 127..128
                          lib/elliptic/curve/edwards.js on lines 129..130
                          lib/elliptic/curve/edwards.js on lines 131..132
                          lib/elliptic/curve/mont.js on lines 38..39
                          lib/elliptic/curve/mont.js on lines 40..41
                          lib/elliptic/curve/short.js on lines 265..266
                          lib/elliptic/curve/short.js on lines 501..502
                          lib/elliptic/curve/short.js on lines 503..504
                          lib/elliptic/curve/short.js on lines 505..506

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 45.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Parsing error: Invalid ecmaVersion.
                          Open

                          'use strict';
                          Severity: Minor
                          Found in lib/elliptic/curve/short.js by eslint

                          For more information visit Source: http://eslint.org/docs/rules/

                          There are no issues that match your filters.

                          Category
                          Status