inertia186/obarc

View on GitHub

Showing 13 of 36 total issues

Class Session has 51 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Session
    OPTIONS_KEYS = %i(protocol server_host server_port api_version username
      password base_url logger cookies verify_ssl)
    
    attr_accessor :cookies, :username, :password, :verify_ssl
Severity: Major
Found in lib/obarc/session.rb - About 7 hrs to fix

    Function generateTOC has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function generateTOC() {
      if ($('#filecontents').length === 0) return;
      var _toc = $('<ol class="top"></ol>');
      var show = false;
      var toc = _toc;
    Severity: Major
    Found in doc/js/app.js - About 2 hrs to fix

      Function searchItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      function searchItem() {
        for (var i = 0; i < searchCache.length / 50; i++) {
          var item = searchCache[searchIndex];
          var searchName = (searchString.indexOf('::') != -1 ? item.fullName : item.name);
          var matchString = regexSearchString;
      Severity: Minor
      Found in doc/js/full_list.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method query_listings has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def query_listings(options = {})
            pattern = options.delete(:pattern)
            all_listings = JSON[Api::get_listings(options, self)]
            listings = all_listings['listings']
            
      Severity: Minor
      Found in lib/obarc/session.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fullListSearch has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function fullListSearch() {
        // generate cache
        searchCache = [];
        $('#full_list li').each(function() {
          var link = $(this).find('.object_link a');
      Severity: Minor
      Found in doc/js/full_list.js - About 1 hr to fix

        Method method_missing has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def method_missing(m, *args, &block)
              super unless respond_to_missing?(m)
              
              # Many of the calls to restapi.py are uniform enough for DRY code, but the
              # ones that aren't are mapped here.
        Severity: Minor
        Found in lib/obarc/api.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method method_missing has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def method_missing(m, *args, &block)
              super unless respond_to_missing?(m)
              
              # Many of the calls to restapi.py are uniform enough for DRY code, but the
              # ones that aren't are mapped here.
        Severity: Minor
        Found in lib/obarc/api.rb - About 1 hr to fix

          Method execute has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              def execute(options = {})
                if options[:method] == :post
                  options[:headers][:content_type] = 'application/x-www-form-urlencoded'
                end
                  
          Severity: Minor
          Found in lib/obarc/api.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method query_listings has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def query_listings(options = {})
                pattern = options.delete(:pattern)
                all_listings = JSON[Api::get_listings(options, self)]
                listings = all_listings['listings']
                
          Severity: Minor
          Found in lib/obarc/session.rb - About 1 hr to fix

            Function summaryToggle has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function summaryToggle() {
              $('.summary_toggle').click(function() {
                if (localStorage) {
                  localStorage.summaryCollapsed = $(this).text();
                }
            Severity: Minor
            Found in doc/js/app.js - About 1 hr to fix

              Function linkList has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function linkList() {
                $('#full_list li, #full_list li a:last').click(function(evt) {
                  if ($(this).hasClass('toggle')) return true;
                  if (this.tagName.toLowerCase() == "li") {
                    if ($(this).find('.object_link a').length === 0) {
              Severity: Minor
              Found in doc/js/full_list.js - About 1 hr to fix

                Method upload_contract_images_with has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def upload_contract_images_with(symbol, contract = {})
                      contract[:images] = [contract.delete(symbol)].flatten.map do |image|
                        response = if image.size < 2000 && image =~ URI::ABS_URI
                          upload_image(image: open(image, 'rb'))
                        else
                Severity: Minor
                Found in lib/obarc/session.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def initialize(options = {})
                      OPTIONS_KEYS.each do |k|
                        value = if options.key?(k)
                          options[k]
                        else
                Severity: Minor
                Found in lib/obarc/session.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language