Sign upLogin

infusionvlc/infusion

View on GitHub
Star

Showing 4 of 368 total issues

Method create has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    auth = request.env['omniauth.auth']
    @identity = Identity.find_with_omniauth(auth)

    if @identity.nil?
Severity: Minor
Found in app/controllers/sessions_controller.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    auth = request.env['omniauth.auth']
    @identity = Identity.find_with_omniauth(auth)

    if @identity.nil?
    Severity: Minor
    Found in app/controllers/sessions_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def reply
    if params[:result][:action] == 'getNextMeetupDate'
      msg = nextMeetupDate
    elsif params[:result][:action] == 'getNextMeetupSpeaker'
      context = params[:result][:contexts].any? {|context| context[:name].downcase == 'nextmeetup'}
    Severity: Minor
    Found in app/controllers/webhook_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method notify_proposal has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def notify_proposal(activity, user)
    @user = user
    @activity = activity
    I18n.with_locale(@user.locale) do
      if @activity.objective_type == 'Assistance' && @user.notify_comments
    Severity: Minor
    Found in app/mailers/notification_mailer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language