Sign upLogin

inossidabile/protector-cancan

View on GitHub
Star

Showing 2 of 2 total issues

Method can_with_protector? has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

          def can_with_protector?(action, entity_set, *extra_args)
            if entity_set.is_a? Hash
              entity = entity_set.values.first
            else
              entity = entity_set
Severity: Minor
Found in lib/protector/cancan/ability.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method included has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.included(mod)
        mod.class_eval do

          def can_with_protector?(action, entity_set, *extra_args)
            if entity_set.is_a? Hash
Severity: Minor
Found in lib/protector/cancan/ability.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language