insideout10/wordlift-plugin-js

View on GitHub
app/admin_files/media-models.js

Summary

Maintainability
D
2 days
Test Coverage

File media-models.js has 526 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global _wpMediaModelsL10n:false */
window.wp = window.wp || {};

(function($){
    var Attachment, Attachments, Query, compare, l10n, media;
Severity: Major
Found in app/admin_files/media-models.js - About 1 day to fix

    Function sync has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            sync: function( method, model, options ) {
                // If the attachment does not yet have an `id`, return an instantly
                // rejected promise. Otherwise, all of our requests will fail.
                if ( _.isUndefined( this.id ) )
                    return $.Deferred().rejectWith( this ).promise();
    Severity: Minor
    Found in app/admin_files/media-models.js - About 1 hr to fix

      Function get has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              get: (function(){
                  var queries = [];
      
                  return function( props, options ) {
                      var args     = {},
      Severity: Minor
      Found in app/admin_files/media-models.js - About 1 hr to fix

        Function fit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                fit: function( dimensions ) {
                    var width     = dimensions.width,
                        height    = dimensions.height,
                        maxWidth  = dimensions.maxWidth,
                        maxHeight = dimensions.maxHeight,
        Severity: Minor
        Found in app/admin_files/media-models.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                          return media.ajax( options ).done( function() {
                              this.destroyed = true;
                          }).fail( function() {
                              this.destroyed = false;
                          });
          Severity: Major
          Found in app/admin_files/media-models.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return false;
            Severity: Major
            Found in app/admin_files/media-models.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return Backbone.Model.prototype.sync.apply( this, arguments );
              Severity: Major
              Found in app/admin_files/media-models.js - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if ( ! this.get('nonces') || ! this.get('nonces').update )
                                    return $.Deferred().rejectWith( this ).promise();
                Severity: Major
                Found in app/admin_files/media-models.js and 1 other location - About 1 hr to fix
                app/admin_files/media-models.js on lines 251..252

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ( ! this.get('nonces') || ! this.get('nonces').update )
                                return $.Deferred().rejectWith( this ).promise();
                Severity: Major
                Found in app/admin_files/media-models.js and 1 other location - About 1 hr to fix
                app/admin_files/media-models.js on lines 185..186

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status