Sign upLogin

insideout10/wordlift-plugin-js

View on GitHub
Star
bower_components/leaflet/src/core/Events.js

Summary

Maintainability
C
1 day
Test Coverage

Function removeEventListener has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    removeEventListener: function (types, fn, context) { // ([String, Function, Object]) or (Object[, Object])

        if (!this[eventsKey]) {
            return this;
        }
Severity: Minor
Found in bower_components/leaflet/src/core/Events.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function removeEventListener has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    removeEventListener: function (types, fn, context) { // ([String, Function, Object]) or (Object[, Object])

        if (!this[eventsKey]) {
            return this;
        }
Severity: Minor
Found in bower_components/leaflet/src/core/Events.js - About 1 hr to fix

    Function addEventListener has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        addEventListener: function (types, fn, context) { // (String, Function[, Object]) or (Object[, Object])

        // types can be a map of types/handlers
        if (L.Util.invokeEach(types, this.addEventListener, this, fn, context)) { return this; }
    Severity: Minor
    Found in bower_components/leaflet/src/core/Events.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fireEvent has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        fireEvent: function (type, data) { // (String[, Object])
        if (!this.hasEventListeners(type)) {
            return this;
        }
    Severity: Minor
    Found in bower_components/leaflet/src/core/Events.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addEventListener has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        addEventListener: function (types, fn, context) { // (String, Function[, Object]) or (Object[, Object])

        // types can be a map of types/handlers
        if (L.Util.invokeEach(types, this.addEventListener, this, fn, context)) { return this; }
    Severity: Minor
    Found in bower_components/leaflet/src/core/Events.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              if ((listeners[j].action === fn) && (!context || (listeners[j].context === context))) {
                            removed = listeners.splice(j, 1);
                            // set the old action to a no-op, because it is possible
                            // that the listener is being iterated over as part of a dispatch
                            removed[0].action = L.Util.falseFn;
      Severity: Major
      Found in bower_components/leaflet/src/core/Events.js - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    for (i = 0, len = listeners.length; i < len; i++) {
                listeners[i].action.call(listeners[i].context, event);
            }
        Severity: Major
        Found in bower_components/leaflet/src/core/Events.js and 1 other location - About 1 hr to fix
        bower_components/leaflet/src/core/Events.js on lines 150..152

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        for (i = 0, len = listeners.length; i < len; i++) {
                    listeners[i].action.call(listeners[i].context, event);
                }
        Severity: Major
        Found in bower_components/leaflet/src/core/Events.js and 1 other location - About 1 hr to fix
        bower_components/leaflet/src/core/Events.js on lines 138..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status