Showing 4 of 11 total issues
Method validate_args has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def validate_args(opts)
@token = opts.fetch :token, ENV['token']
@ipa = opts.fetch :ipa, ARGV.first
@build_url = opts.fetch :build_url, ENV['build_url']
@gerrit_env = opts.fetch :gerrit, ENV['GERRIT_REFSPEC']- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method upload_build has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def upload_build(ipa, options)
options[:ipa] = Faraday::UploadIO.new(ipa, 'application/octet-stream') if ipa and File.exist?(ipa)
if dsym_filename = options.delete(:dsym_filename)
options[:dsym] = Faraday::UploadIO.new(dsym_filename, 'application/octet-stream')- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def run(opts = {})
validate_args opts
tries = @tries # required for tries to be in scope for 'retry'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method configure_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def configure_options
gerrit = gerrit_refspec
log = git_log
release_notes = "#{gerrit}\n\n#{log}"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"