Showing 10 of 10 total issues
Method load_scenario_yaml has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def load_scenario_yaml(yaml_file, filter = nil)
scenarios = YAML.load_file(yaml_file)
scenarios.each do |tc_name, facts|
next if tc_name =~ /^__/- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_relationships has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def validate_relationships(catalog)
catalog.resources.each do |resource|
next unless resource.is_a?(Puppet::Resource)
resource.each do |param, value|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run_tests! has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def run_tests!
@out.puts "[INFO] Using puppet #{@puppet_adapter.version}"
run_start = Time.now
proc_count = Parallel.processor_countMethod run_tests! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def run_tests!
@out.puts "[INFO] Using puppet #{@puppet_adapter.version}"
run_start = Time.now
proc_count = Parallel.processor_count- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method setup has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def setup
puppet_config = {
:config_dir => @config_dir,
:manifest_path => @manifest_path,
:module_paths => @module_paths,Method init_config has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def init_config()
config = @config
manifest_path = config[:manifest_path]
module_paths = config[:module_paths]
config_dir = config[:config_dir]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method init_config has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def init_config()
config = @config
manifest_path = config[:manifest_path]
module_paths = config[:module_paths]
config_dir = config[:config_dir]Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def initialize(config)
super(config)
require 'puppet/test/test_helper'
parser = config[:parser]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_if_resource_exists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def check_if_resource_exists(catalog, resource, param, value)
case value
when Array
value.each { |v| check_if_resource_exists(catalog, resource, param, v) }
when Puppet::Resource- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method setup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def setup
puppet_config = {
:config_dir => @config_dir,
:manifest_path => @manifest_path,
:module_paths => @module_paths,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"