inventid/iaas

View on GitHub
src/databases/postgresql.js

Summary

Maintainability
C
1 day
Test Coverage

Function postgresql has 214 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function postgresql() {
  const configs = {
    user: config.get('postgresql.user'),
    database: config.get('postgresql.database'),
    password: config.get('postgresql.password'),
Severity: Major
Found in src/databases/postgresql.js - About 1 day to fix

    Function postgresql has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function postgresql() {
      const configs = {
        user: config.get('postgresql.user'),
        database: config.get('postgresql.database'),
        password: config.get('postgresql.password'),
    Severity: Minor
    Found in src/databases/postgresql.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addToCache has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

      async function addToCache(params, url, renderedAt) {
        const vars = [params.name,
          params.width,
          params.height,
          params.fit,
    Severity: Minor
    Found in src/databases/postgresql.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

        async function consumeToken(token, id) {
          const vars = [token, id];
          const metric = timingMetric(DATABASE, {tags: {sqlOperation: 'consumeToken'}});
          try {
            const result = await pool.query(consumeTokens, vars);
      Severity: Major
      Found in src/databases/postgresql.js and 1 other location - About 4 hrs to fix
      src/databases/postgresql.js on lines 109..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 117.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

        async function markUploadAsCompleted(token, id) {
          const vars = [token, id];
          const metric = timingMetric(DATABASE, {tags: {sqlOperation: 'markUploadAsCompleted'}});
          try {
            const result = await pool.query(markAsCompleted, vars);
      Severity: Major
      Found in src/databases/postgresql.js and 1 other location - About 4 hrs to fix
      src/databases/postgresql.js on lines 89..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 117.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status