Sign upLogin

investtools/extensible-duck

View on GitHub
Star
src/extensible-duck.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function mergeDeep has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

function mergeDeep(target, ...sources) {
  if (!sources.length) return target
  const source = sources.shift()

  if (Array.isArray(target)) {
Severity: Minor
Found in src/extensible-duck.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function extend has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  extend(options) {
    if (isFunction(options)) {
      options = options(this)
    }
    options = assignDefaults(options)
Severity: Minor
Found in src/extensible-duck.js - About 1 hr to fix

    Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor(options) {
    options = assignDefaults(options)
    const {
      namespace,
      store,
    Severity: Minor
    Found in src/extensible-duck.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

              if (!target[key]) {
          target[key] = source[key]
        } else {
          mergeDeep(target[key], source[key])
        }
      Severity: Major
      Found in src/extensible-duck.js - About 45 mins to fix

        Function extend has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          extend(options) {
    if (isFunction(options)) {
      options = options(this)
    }
    options = assignDefaults(options)
        Severity: Minor
        Found in src/extensible-duck.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              creators: duck => {
        const parentCreators = parent.creators(duck)
        return { ...parentCreators, ...options.creators(duck, parentCreators) }
      },
        Severity: Minor
        Found in src/extensible-duck.js and 1 other location - About 30 mins to fix
        src/extensible-duck.js on lines 210..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              sagas: duck => {
        const parentSagas = parent.sagas(duck)
        return { ...parentSagas, ...options.sagas(duck, parentSagas) }
      },
        Severity: Minor
        Found in src/extensible-duck.js and 1 other location - About 30 mins to fix
        src/extensible-duck.js on lines 218..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status