iranianpep/code-jetter

View on GitHub

Showing 251 of 1,173 total issues

Method where has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function where(array $criteria)
    {
        if (!empty($criteria)) {
            $where = ' WHERE ';

Severity: Major
Found in core/database/QueryMaker.php - About 2 hrs to fix

    Method testValidateUsername has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testValidateUsername()
        {
            $app = App::getInstance();
            $app->init('dev');
    
    
    Severity: Major
    Found in tests/ValidatorTest.php - About 2 hrs to fix

      Method testValidateSize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testValidateSize()
          {
              $app = App::getInstance();
              $app->init('dev');
      
      
      Severity: Major
      Found in tests/ValidatorTest.php - About 2 hrs to fix

        Method update has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function update(
                array $criteria,
                array $inputs,
                array $fieldsValues,
                $limit = 0,
        Severity: Major
        Found in components/user/mappers/UserMapper.php - About 2 hrs to fix

          Method validate has 71 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function validate()
              {
                  $output = new Output();
                  if ($this->isAlreadyValidated()) {
                      // return the current output is already validated
          Severity: Major
          Found in core/security/Validator.php - About 2 hrs to fix

            Function getSelectFromTables has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getSelectFromTables($fromColumns = null)
                {
                    $joinedSelect = [];
                    $counter = 1;
                    $from = '';
            Severity: Minor
            Found in core/database/QueryMaker.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getAccessRole has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getAccessRole($urlPath, $roles = [])
                {
                    if (empty($roles)) {
                        $roles = Registry::getConfigClass()->get('roles');
                    }
            Severity: Minor
            Found in core/Router.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function regexMatch has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                public function regexMatch($pattern, $path)
                {
                    if (empty($pattern) || empty($path)) {
                        return false;
                    }
            Severity: Minor
            Found in core/Router.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getPersonalizedMenu has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getPersonalizedMenu()
                {
                    $routeInfo = Registry::getRouterClass()->getLastRoute();
            
                    if (!$routeInfo instanceof RouteInfo) {
            Severity: Minor
            Found in core/layout/blocks/Menu.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method listUsers has 68 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function listUsers()
                {
                    // for pagination - for simple router url path is enough, for regex ones base path is needed
                    $pager = new Pager($this->getURLParameters(), $this->getBasePath(), $this->getRouteInfo()->getUrl());
            
            
            Severity: Major
            Found in components/user/controllers/MemberUserController.php - About 2 hrs to fix

              Method testValidateRequired has 67 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testValidateRequired()
                  {
                      $app = App::getInstance();
                      $app->init('dev');
              
              
              Severity: Major
              Found in tests/ValidatorTest.php - About 2 hrs to fix

                File UserAuthentication.php has 278 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                /**
                 * Created by PhpStorm.
                 * User: ehsanabbasi
                 * Date: 24/02/16
                Severity: Minor
                Found in components/user/services/UserAuthentication.php - About 2 hrs to fix

                  User has 24 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  abstract class User extends BaseModel
                  {
                      protected $name;
                      protected $username;
                      protected $email;
                  Severity: Minor
                  Found in components/user/models/User.php - About 2 hrs to fix

                    BaseBlock has 24 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    abstract class BaseBlock
                    {
                        protected $view;
                        protected $config;
                        protected $html;
                    Severity: Minor
                    Found in core/layout/blocks/BaseBlock.php - About 2 hrs to fix

                      Method testValidateId has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function testValidateId()
                          {
                              $app = App::getInstance();
                              $app->init('dev');
                      
                      
                      Severity: Major
                      Found in tests/ValidatorTest.php - About 2 hrs to fix

                        Function getInputs has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function getInputs(array $inputKeys = [], $requestMethod = null)
                            {
                                if (isset($this->inputs)) {
                                    return $this->inputs;
                                }
                        Severity: Minor
                        Found in core/io/Request.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method testGenerateCheckboxes has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function testGenerateCheckboxes()
                            {
                                $utility = new HtmlUtility();
                        
                                $ios = [
                        Severity: Major
                        Found in tests/HtmlUtilityTest.php - About 2 hrs to fix

                          ErrorHandler has 23 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class ErrorHandler
                          {
                              private $configs;
                              private $logger;
                          
                          
                          Severity: Minor
                          Found in core/ErrorHandler.php - About 2 hrs to fix

                            RouteInfo has 23 functions (exceeds 20 allowed). Consider refactoring.
                            Open

                            class RouteInfo
                            {
                                private $routeType;
                                private $requestMethod;
                                private $url;
                            Severity: Minor
                            Found in core/RouteInfo.php - About 2 hrs to fix

                              Pager has 23 functions (exceeds 20 allowed). Consider refactoring.
                              Open

                              class Pager extends BaseBlock
                              {
                                  private $total;
                                  private $totalPagesNo;
                                  private $currentPage;
                              Severity: Minor
                              Found in core/layout/blocks/Pager.php - About 2 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language