isikyus/aeldardin-rooms

View on GitHub
canvas_renderer.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function addListeners has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var addListeners = function(canvas, store) {
    var regions = hitRegions(canvas);

    regions.reset();
    var map = store.getState().map.state;
Severity: Major
Found in canvas_renderer.js - About 2 hrs to fix

    Expected '===' and instead saw '=='.
    Open

          if (currentAction && currentAction.type == 'map.rooms.add') {
    Severity: Minor
    Found in canvas_renderer.js by eslint

    Require === and !== (eqeqeq)

    It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

    The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

    • [] == false
    • [] == ![]
    • 3 == "03"

    If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

    Rule Details

    This rule is aimed at eliminating the type-unsafe equality operators.

    Examples of incorrect code for this rule:

    /*eslint eqeqeq: "error"*/
    
    if (x == 42) { }
    
    if ("" == text) { }
    
    if (obj.getStuff() != undefined) { }

    The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

    Options

    always

    The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

    Examples of incorrect code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a == b
    foo == true
    bananas != 1
    value == undefined
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    Examples of correct code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a === b
    foo === true
    bananas !== 1
    value === undefined
    typeof foo === 'undefined'
    'hello' !== 'world'
    0 === 0
    true === true
    foo === null

    This rule optionally takes a second argument, which should be an object with the following supported properties:

    • "null": Customize how this rule treats null literals. Possible values:
      • always (default) - Always use === or !==.
      • never - Never use === or !== with null.
      • ignore - Do not apply this rule to null.

    smart

    The "smart" option enforces the use of === and !== except for these cases:

    • Comparing two literal values
    • Evaluating the value of typeof
    • Comparing against null

    Examples of incorrect code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    // comparing two variables requires ===
    a == b
    
    // only one side is a literal
    foo == true
    bananas != 1
    
    // comparing to undefined requires ===
    value == undefined

    Examples of correct code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    allow-null

    Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

    ["error", "always", {"null": "ignore"}]

    When Not To Use It

    If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

    Unnecessary semicolon.
    Open

        };
    Severity: Minor
    Found in canvas_renderer.js by eslint

    disallow unnecessary semicolons (no-extra-semi)

    Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

    Rule Details

    This rule disallows unnecessary semicolons.

    Examples of incorrect code for this rule:

    /*eslint no-extra-semi: "error"*/
    
    var x = 5;;
    
    function foo() {
        // code
    };

    Examples of correct code for this rule:

    /*eslint no-extra-semi: "error"*/
    
    var x = 5;
    
    var foo = function() {
        // code
    };

    When Not To Use It

    If you intentionally use extra semicolons then you can disable this rule.

    Related Rules

    TODO found
    Open

        // TODO: think about key placement.
    Severity: Minor
    Found in canvas_renderer.js by fixme

    TODO found
    Open

      // TODO: extract so tests can use it.
    Severity: Minor
    Found in canvas_renderer.js by fixme

    TODO found
    Open

         * TODO: might be better to remember which way we're dragging.
    Severity: Minor
    Found in canvas_renderer.js by fixme

    There are no issues that match your filters.

    Category
    Status