Sign upLogin

isprambiente/medplan

View on GitHub
Star
app/javascript/controllers/users_controller.js

Summary

Maintainability
F
5 days
Test Coverage

Function edit has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

  edit(event) {
    var btnCanc, btnSave, buttons, container, editDiv, el, form, i, len, oldDate, opt, option, option_splitted, options, target, userId, user_id;

    target = event.target;
    if (target.classList.contains('editable')) {
Severity: Minor
Found in app/javascript/controllers/users_controller.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function edit has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  edit(event) {
    var btnCanc, btnSave, buttons, container, editDiv, el, form, i, len, oldDate, opt, option, option_splitted, options, target, userId, user_id;

    target = event.target;
    if (target.classList.contains('editable')) {
Severity: Major
Found in app/javascript/controllers/users_controller.js - About 5 hrs to fix

    Function update has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      update(event) {
    var container, editor, input, link, target, url, user_id, value;

    target = event.currentTarget;
    editor = target.parentNode;
    Severity: Minor
    Found in app/javascript/controllers/users_controller.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File users_controller.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Controller } from "@hotwired/stimulus";
import Rails from "@rails/ujs";
import Timeout from 'smart-timeout';
import Swal from 'sweetalert2';
    Severity: Minor
    Found in app/javascript/controllers/users_controller.js - About 2 hrs to fix

      Function update has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        update(event) {
    var container, editor, input, link, target, url, user_id, value;

    target = event.currentTarget;
    editor = target.parentNode;
      Severity: Minor
      Found in app/javascript/controllers/users_controller.js - About 1 hr to fix

        Function send has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          send(message, level = 'success', force = false, timeout = 2000, toast = true) {
    var options;
    options = {
      toast: level === 'error' ? false : toast,
      icon: level,
        Severity: Minor
        Found in app/javascript/controllers/users_controller.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                    if (option.indexOf("||") >= 0) {
              option_splitted = option.split("||");
              opt.value = option_splitted[0];
              opt.text = option_splitted[1];
            } else {
        Severity: Major
        Found in app/javascript/controllers/users_controller.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if (target.dataset.fieldValue === "") {
              opt.selected = true;
            }
          Severity: Major
          Found in app/javascript/controllers/users_controller.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        if (option === target.dataset.fieldValue) {
              opt.selected = true;
            }
            Severity: Major
            Found in app/javascript/controllers/users_controller.js - About 45 mins to fix

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                send(message, level = 'success', force = false, timeout = 2000, toast = true) {
    var options;
    options = {
      toast: level === 'error' ? false : toast,
      icon: level,
              Severity: Major
              Found in app/javascript/controllers/users_controller.js and 2 other locations - About 1 day to fix
              app/javascript/controllers/audits_controller.js on lines 136..162
              app/javascript/controllers/message_controller.js on lines 23..49

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 263.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                        btnSave.innerHTML = `<i class='fa fa-save' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Salva' : ''}`;
              Severity: Major
              Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
              app/javascript/controllers/users_controller.js on lines 134..134
              app/javascript/controllers/users_controller.js on lines 142..142
              app/javascript/controllers/users_controller.js on lines 160..160

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                        btnCanc.innerHTML = `<i class='fa fa-times' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Annulla' : ''}`;
              Severity: Major
              Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
              app/javascript/controllers/users_controller.js on lines 134..134
              app/javascript/controllers/users_controller.js on lines 142..142
              app/javascript/controllers/users_controller.js on lines 153..153

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      btnCanc.innerHTML = `<i class='fa fa-times' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Annulla' : ''}`;
              Severity: Major
              Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
              app/javascript/controllers/users_controller.js on lines 134..134
              app/javascript/controllers/users_controller.js on lines 153..153
              app/javascript/controllers/users_controller.js on lines 160..160

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      btnSave.innerHTML = `<i class='fa fa-save' style=${target.dataset.fieldType === 'textarea' ? '' : 'padding-right:0px'}></i>${target.dataset.fieldType === 'textarea' ? ' Salva' : ''}`;
              Severity: Major
              Found in app/javascript/controllers/users_controller.js and 3 other locations - About 1 hr to fix
              app/javascript/controllers/users_controller.js on lines 142..142
              app/javascript/controllers/users_controller.js on lines 153..153
              app/javascript/controllers/users_controller.js on lines 160..160

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (target.dataset.fieldType === 'textarea') {
          el = document.createElement("TEXTAREA");
          el.className = "textarea editor is-radiusless";
          el.style = 'width:80%;';
          el.innerHTML = target.dataset.fieldValue;
              Severity: Major
              Found in app/javascript/controllers/users_controller.js and 1 other location - About 1 hr to fix
              app/javascript/controllers/users_controller.js on lines 110..115

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    } else {
        el = document.createElement("INPUT");
        el.className = "input editor is-radiusless";
        el.style = "width:60%;";
        el.value = target.dataset.fieldValue;
              Severity: Major
              Found in app/javascript/controllers/users_controller.js and 1 other location - About 1 hr to fix
              app/javascript/controllers/users_controller.js on lines 44..49

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status