Sign upLogin

ivaynberg/select2

View on GitHub
Star
src/js/select2/defaults.js

Summary

Maintainability
D
1 day
Test Coverage

Function apply has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  Defaults.prototype.apply = function (options) {
    options = $.extend(true, {}, this.defaults, options);

    if (options.dataAdapter == null) {
      if (options.ajax != null) {
Severity: Major
Found in src/js/select2/defaults.js - About 5 hrs to fix

    File defaults.js has 326 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    define([
  'jquery',

  './results',
    Severity: Minor
    Found in src/js/select2/defaults.js - About 3 hrs to fix

      Function reset has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Defaults.prototype.reset = function () {
    function stripDiacritics (text) {
      // Used 'uni range + named function' from http://jsperf.com/diacritics/18
      function match(a) {
        return DIACRITICS[a] || a;
      Severity: Major
      Found in src/js/select2/defaults.js - About 2 hrs to fix

        Function _processTranslations has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          Defaults.prototype._processTranslations = function (languages, debug) {
    var translations = new Translation();

    for (var l = 0; l < languages.length; l++) {
      var languageData = new Translation();
        Severity: Minor
        Found in src/js/select2/defaults.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                return null;
          Severity: Major
          Found in src/js/select2/defaults.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for (var l = 0; l < options.language.length; l++) {
      var language = options.language[l];

      if (uniqueLanguages.indexOf(language) === -1) {
        uniqueLanguages.push(language);
            Severity: Minor
            Found in src/js/select2/defaults.js and 1 other location - About 50 mins to fix
            src/js/select2/data/select.js on lines 51..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status