Sign upLogin

jacob-meacham/brew-github-bottles

View on GitHub
Star

Showing 3 of 3 total issues

Method pour has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def pour(cache_root, formula)
    asset_uri = URI(@project_basepath + "releases/assets/#{@bottle_asset_id}")

    here_cache = (cache_root/formula.name)
    here_cache.mkpath
Severity: Minor
Found in lib/homebrew/github/bottles.rb - About 1 hr to fix

    Method inner_bottled? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def inner_bottled?(formula)
    # Get the assets from github for this formula
    release_uri = URI(@project_basepath + "releases/tags/bottles")

    req = Net::HTTP::Get.new(release_uri)
    Severity: Minor
    Found in lib/homebrew/github/bottles.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pour has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def pour(cache_root, formula)
    asset_uri = URI(@project_basepath + "releases/assets/#{@bottle_asset_id}")

    here_cache = (cache_root/formula.name)
    here_cache.mkpath
    Severity: Minor
    Found in lib/homebrew/github/bottles.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language