Sign upLogin

jakearchibald/tweetdeck-prototype

View on GitHub
Star
www/static/js/lib/interval.js

Summary

Maintainability
D
3 days
Test Coverage

Function makeIntervalConstructor has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function makeIntervalConstructor(compareValues) {

    /**
     * Interval
     * http://en.wikipedia.org/wiki/Interval_(mathematics)
Severity: Minor
Found in www/static/js/lib/interval.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeIntervalConstructor has 186 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function makeIntervalConstructor(compareValues) {

    /**
     * Interval
     * http://en.wikipedia.org/wiki/Interval_(mathematics)
Severity: Major
Found in www/static/js/lib/interval.js - About 7 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (!isContiguous) {
            // Does an open end-point of one interval match a closed end-point of the other
            // E.g. // [a,b) U [b,c] = [a,c]
            var canConcatThisAndOther = Interval.compareEndpoints(this.to, other.from) === 0 &&
                (this.to.inclusive || other.from.inclusive);
    Severity: Major
    Found in www/static/js/lib/interval.js - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Interval.prototype.fromComparator = function (a, b) {
        var ordering = Interval.compareEndpoints(a, b);
        if (ordering === 0) {
            // Inclusive should sort before exclusive
            ordering = b.inclusive - a.inclusive;
      Severity: Major
      Found in www/static/js/lib/interval.js and 1 other location - About 1 hr to fix
      www/static/js/lib/interval.js on lines 267..274

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Interval.prototype.toComparator = function (a, b) {
        var ordering = Interval.compareEndpoints(a, b);
        if (ordering === 0) {
            // Exclusive should sort before inclusive
            ordering = a.inclusive - b.inclusive;
      Severity: Major
      Found in www/static/js/lib/interval.js and 1 other location - About 1 hr to fix
      www/static/js/lib/interval.js on lines 258..265

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              return this.fromComparator(this.from, other.from) === 0 &&
               this.toComparator(this.to, other.to) === 0;
      Severity: Minor
      Found in www/static/js/lib/interval.js and 1 other location - About 40 mins to fix
      www/static/js/lib/interval.js on lines 250..251

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              return this.fromComparator(this.from, other.from) >= 0 &&
            this.toComparator(this.to, other.to) <= 0;
      Severity: Minor
      Found in www/static/js/lib/interval.js and 1 other location - About 40 mins to fix
      www/static/js/lib/interval.js on lines 166..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  (typeof this.from.value === 'object' ?
                JSON.stringify(this.from.value) :
                this.from.value),
      Severity: Minor
      Found in www/static/js/lib/interval.js and 1 other location - About 30 mins to fix
      www/static/js/lib/interval.js on lines 287..289

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  (typeof this.to.value === 'object' ?
                JSON.stringify(this.to.value) :
                this.to.value),
      Severity: Minor
      Found in www/static/js/lib/interval.js and 1 other location - About 30 mins to fix
      www/static/js/lib/interval.js on lines 283..285

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status