Sign upLogin

jamesmoriarty/scorched-earth-rb

View on GitHub
Star

Showing 4 of 4 total issues

Method call has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def call(color_1, color_2, weighting_type = :graphic_arts)
        color_1 = to_lab(color_1)
        color_2 = to_lab(color_2)

        case weighting_type
Severity: Minor
Found in lib/scorched_earth/services/cie94.rb - About 1 hr to fix

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(x, y, velocity_x, velocity_y, trajectory = Trajectory.new)
    Severity: Minor
    Found in lib/scorched_earth/objects/shot.rb - About 35 mins to fix

      Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def call(center_x, radius, center_y = array[center_x])
        new_array = array.dup
        circle(radius) do |offset_x, offset_y|
          x = center_x + offset_x
          y = array[x]
      Severity: Minor
      Found in lib/scorched_earth/services/deform.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method circle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def circle(radius)
      return enum_for(:circle, radius) unless block_given?

      x = -radius
      Severity: Minor
      Found in lib/scorched_earth/helpers.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language