jaredhanson/oauth2orize

View on GitHub

Showing 52 of 87 total issues

Function password has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  return function password(req, res, next) {
    if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
    
    // The 'user' property of `req` holds the authenticated user.  In the case
    // of the token endpoint, the property will contain the OAuth 2.0 client.
Severity: Major
Found in lib/exchange/password.js - About 2 hrs to fix

    File server.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * Module dependencies.
     */
    var SessionStore = require('./txn/session')
      , UnorderedList = require('./unorderedlist')
    Severity: Minor
    Found in lib/server.js - About 2 hrs to fix

      Function refresh_token has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        return function refresh_token(req, res, next) {
          if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
          
          // The 'user' property of `req` holds the authenticated user.  In the case
          // of the token endpoint, the property will contain the OAuth 2.0 client.
      Severity: Minor
      Found in lib/exchange/refreshToken.js - About 2 hrs to fix

        Function immediated has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function immediated(err, allow, info, locals) {
              if (err) { return next(err); }
              if (allow) {
                req.oauth2.res = info || {};
                req.oauth2.res.allow = true;
        Severity: Minor
        Found in lib/middleware/resume.js - About 2 hrs to fix

          Function response has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function response(txn, res, complete, next) {
              var mode = 'query'
                , respond;
              if (txn.req && txn.req.responseMode) {
                mode = txn.req.responseMode;
          Severity: Minor
          Found in lib/grant/code.js - About 1 hr to fix

            Function client_credentials has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              return function client_credentials(req, res, next) {
                if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
                
                // The 'user' property of `req` holds the authenticated user.  In the case
                // of the token endpoint, the property will contain the OAuth 2.0 client.
            Severity: Minor
            Found in lib/exchange/clientCredentials.js - About 1 hr to fix

              Function response has 48 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function response(txn, res, complete, next) {
                  var mode = 'fragment'
                    , respond;
                  if (txn.req && txn.req.responseMode) {
                    mode = txn.req.responseMode;
              Severity: Minor
              Found in lib/grant/token.js - About 1 hr to fix

                Function exports has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function(server, options, parse, complete) {
                  if (typeof options == 'function') {
                    complete = parse;
                    parse = options;
                    options = undefined;
                Severity: Minor
                Found in lib/middleware/decision.js - About 1 hr to fix

                  Function exports has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(options, issue) {
                    if (typeof options == 'function') {
                      issue = options;
                      options = undefined;
                    }
                  Severity: Minor
                  Found in lib/exchange/authorizationCode.js - About 1 hr to fix

                    Function exports has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function(options) {
                      options = options || {};
                      
                      var mode = options.mode || 'direct'
                        , fragment = options.fragment || ['token']
                    Severity: Minor
                    Found in lib/middleware/errorHandler.js - About 1 hr to fix

                      Function _respond has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                      Open

                      Server.prototype._respond = function(txn, res, complete, cb) {
                        if (cb === undefined) {
                          cb = complete;
                          complete = undefined;
                        }
                      Severity: Minor
                      Found in lib/server.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function immediated has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              function immediated(err, allow, info, locals) {
                                if (err) { return next(err); }
                                if (allow) {
                                  req.oauth2.res = info || {};
                                  req.oauth2.res.allow = true;
                      Severity: Minor
                      Found in lib/middleware/authorization.js - About 1 hr to fix

                        Function _parse has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                        Server.prototype._parse = function(type, req, cb) {
                          var ultype = new UnorderedList(type)
                            , stack = this._reqParsers
                            , areq = {};
                          
                        Severity: Minor
                        Found in lib/server.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function exports has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                        module.exports = function(server, options) {
                          options = options || {};
                          
                          if (!server) { throw new TypeError('oauth2orize.authorizationErrorHandler middleware requires a server argument'); }
                          
                        Severity: Minor
                        Found in lib/middleware/authorizationErrorHandler.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function authorization_code has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          return function authorization_code(req, res, next) {
                            if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
                            
                            // The 'user' property of `req` holds the authenticated user.  In the case
                            // of the token endpoint, the property will contain the OAuth 2.0 client.
                        Severity: Minor
                        Found in lib/exchange/authorizationCode.js - About 1 hr to fix

                          Function decision has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            return function decision(req, res, next) {
                              if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
                              if (!req.oauth2) { return next(new Error('OAuth2orize requires transaction support. Did you forget oauth2orize.transactionLoader(...)?')); }
                              
                              parse(req, function(err, ares, locals) {
                          Severity: Minor
                          Found in lib/middleware/decision.js - About 1 hr to fix

                            Function errorHandler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              return function errorHandler(err, req, res, next) {
                                if (mode == 'direct') {
                                  if (err.status) { res.statusCode = err.status; }
                                  if (!res.statusCode || res.statusCode < 400) { res.statusCode = 500; }
                                  
                            Severity: Minor
                            Found in lib/middleware/errorHandler.js - About 1 hr to fix

                              Function deserializeClient has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                              Open

                              Server.prototype.deserializeClient = function(fn, done) {
                                if (typeof fn === 'function') {
                                  return this._deserializers.push(fn);
                                }
                                
                              Severity: Minor
                              Found in lib/server.js - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function grant has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              Server.prototype.grant = function(type, phase, fn) {
                                if (typeof type == 'object') {
                                  // sig: grant(mod)
                                  var mod = type;
                                  if (mod.request) { this.grant(mod.name, 'request', mod.request); }
                              Severity: Minor
                              Found in lib/server.js - About 1 hr to fix

                                Function _respond has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                Server.prototype._respond = function(txn, res, complete, cb) {
                                  if (cb === undefined) {
                                    cb = complete;
                                    complete = undefined;
                                  }
                                Severity: Minor
                                Found in lib/server.js - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language