Sign upLogin

jasoncharnes/bank_teller

View on GitHub
Star

Showing 4 of 4 total issues

Class Invoice has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class Invoice
  def initialize(user, invoice)
    @user = user
    @invoice = invoice
  end
Severity: Minor
Found in lib/invoice.rb - About 2 hrs to fix

    Method up has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.up
    unless column_exists? :users, :email
      add_column :users, :email, :string
    end
    Severity: Minor
    Found in lib/generators/bank_teller/templates/add_bank_teller_fields_to_users.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method swap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def swap(plan, *args)
    subscription = stripe_subscription
    subscription.plan = plan
    subscription.prorate = false
    additional_options = args[0]
    Severity: Minor
    Found in lib/subscription.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method invoices has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def invoices(include_pending = false, parameters = {})
    invoices = []
    parameters.merge!({ limit: 24 })
    stripe_invoices = as_stripe_customer.invoices(parameters)
    Severity: Minor
    Found in lib/billable.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language