Sign upLogin

jbender/rx_nav_ruby

View on GitHub
Star

Showing 3 of 3 total issues

Method find_drugs_by_name has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def find_drugs_by_name name
        query = "/drugs?name=#{name}"
        drugs = []
        dg = get_response_hash(query)[:drug_group]
        return nil if dg[:concept_group].nil?
Severity: Minor
Found in lib/rx_nav/rx_norm.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_rxcui has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def get_rxcui
      # Terms use the rxcui for the lookup
      if self.rxcui.nil?
        # Fail if we have a concept without any IDs (that are written so far)
        if self.nui.nil?
Severity: Minor
Found in lib/rx_nav/concept.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method merge_concept has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def merge_concept concept_hash
      if concept_hash.nil? || concept_hash.empty?
        return false
      else
        concept_hash.each do |k,v|
Severity: Minor
Found in lib/rx_nav/concept.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language