Sign upLogin

jcbantuelle/dominion-meteor

View on GitHub
Star
app/cards/guilds/stonemason.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function potion_overpay has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static potion_overpay(game, player_cards, amount, coin_overpay) {
    let potion_overpay = Number(amount)
    if (coin_overpay === 0 && potion_overpay === 0) {
      game.log.push(`  but does not overpay`)
    } else {
Severity: Minor
Found in app/cards/guilds/stonemason.js - About 1 hr to fix

    Function trash_card has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static trash_card(game, player_cards, selected_cards) {
    let selected_card = selected_cards[0]

    let card_trasher = new CardTrasher(game, player_cards, 'hand', selected_cards)
    card_trasher.trash()
    Severity: Minor
    Found in app/cards/guilds/stonemason.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            let eligible_cards = _.filter(game.cards, function(card) {
        return card.count > 0 && card.supply && CardCostComparer.card_less_than(game, selected_card, card.top_card)
      })
      Severity: Major
      Found in app/cards/guilds/stonemason.js and 2 other locations - About 1 hr to fix
      app/cards/intrigue/swindler.js on lines 37..39
      app/cards/promo/dismantle.js on lines 40..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status