Sign upLogin

jcbantuelle/dominion-meteor

View on GitHub
Star
app/game/server/services/discard_event_processor.js

Summary

Maintainability
F
4 days
Test Coverage

Function find_discard_events has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

  find_discard_events() {
    this.discard_events = []
    if (_.includes(DiscardEventProcessor.event_cards(), this.card.name)) {
      if (_.includes(['Tunnel', 'Faithful Hound', 'Village Green'], this.card.name) && this.discarder.game.turn.phase !== 'cleanup') {
        this.discard_events.push(this.card)
Severity: Minor
Found in app/game/server/services/discard_event_processor.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function find_discard_events has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  find_discard_events() {
    this.discard_events = []
    if (_.includes(DiscardEventProcessor.event_cards(), this.card.name)) {
      if (_.includes(['Tunnel', 'Faithful Hound', 'Village Green'], this.card.name) && this.discarder.game.turn.phase !== 'cleanup') {
        this.discard_events.push(this.card)
Severity: Major
Found in app/game/server/services/discard_event_processor.js - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

              if (has_treasures) {
            this.discard_events.push(this.card)
          }
    Severity: Major
    Found in app/game/server/services/discard_event_processor.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

              } else if (this.card.name === 'Alchemist') {
          let has_potions = _.some(this.discarder.player_cards.in_play, function(card) {
            return card.name === 'Potion'
          })
          if (has_potions) {
      Severity: Major
      Found in app/game/server/services/discard_event_processor.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          process() {
    if (!_.isEmpty(this.discard_events)) {
      if (_.size(this.discard_events) === 1) {
        DiscardEventProcessor.discard_event(this.discarder.game, this.discarder.player_cards, this.discard_events, this)
      } else {
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 1 other location - About 1 day to fix
        app/game/server/services/reveal_event_processor.js on lines 21..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 236.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          static discard_event(game, player_cards, selected_cards, discard_event_processor) {
    let card = selected_cards[0]
    let card_object = ClassCreator.create(card.name)
    card_object.discard_event(discard_event_processor.discarder, card)
    let discard_event_index = _.findIndex(discard_event_processor.discard_events, function(event) {
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 1 other location - About 6 hrs to fix
        app/game/server/services/reveal_event_processor.js on lines 43..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } else if (this.card.name === 'Border Guard' && !this.discarder.game.turn.discarded_border_guard) {
          let has_horn = _.some(this.discarder.player_cards.artifacts, function(artifact) {
            return artifact.name == 'Horn'
          })
          if (has_horn) {
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 1 other location - About 2 hrs to fix
        app/game/server/services/discard_event_processor.js on lines 57..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } else if (this.card.name === 'Alchemist') {
          let has_potions = _.some(this.discarder.player_cards.in_play, function(card) {
            return card.name === 'Potion'
          })
          if (has_potions) {
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 1 other location - About 2 hrs to fix
        app/game/server/services/discard_event_processor.js on lines 70..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

          constructor(discarder, card) {
    this.discarder = discarder
    this.card = card
    this.event_id = 9000
    this.find_discard_events()
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 5 other locations - About 55 mins to fix
        app/game/server/services/between_turn_event_processor.js on lines 3..8
        app/game/server/services/end_turn_event_processor.js on lines 7..12
        app/game/server/services/gain_event_processor.js on lines 88..93
        app/game/server/services/start_turn_event_processor.js on lines 23..28
        app/game/server/services/trash_event_processor.js on lines 19..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  let has_treasures = _.some(this.discarder.player_cards.in_play, function(card) {
            return _.includes(_.words(card.types), 'treasure')
          })
        Severity: Minor
        Found in app/game/server/services/discard_event_processor.js and 1 other location - About 50 mins to fix
        app/game/server/services/gain_event_processor.js on lines 104..106

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                let traveller_stack = _.find(this.discarder.game.cards, function(card) {
          return card.name === traveller.name
        })
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 2 other locations - About 40 mins to fix
        app/game/server/services/discard_event_processor.js on lines 90..92
        app/game/server/services/discard_event_processor.js on lines 93..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                  let upgrade_stack = _.find(this.discarder.game.cards, function(stack) {
            return stack.name === traveller.upgrade
          })
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 2 other locations - About 40 mins to fix
        app/game/server/services/discard_event_processor.js on lines 86..88
        app/game/server/services/discard_event_processor.js on lines 93..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                  let discarding_upgrades = _.some(this.discarder.player_cards.in_play, function(card) {
            return card.name === traveller.upgrade
          })
        Severity: Major
        Found in app/game/server/services/discard_event_processor.js and 2 other locations - About 40 mins to fix
        app/game/server/services/discard_event_processor.js on lines 86..88
        app/game/server/services/discard_event_processor.js on lines 90..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status