jdantonio/concurrent-ruby

View on GitHub

Showing 303 of 498 total issues

Avoid deeply nested control flow statements.
Open

                                    if ((p.val = v) == null) {
                                        deleted = true;
                                        t.deleteTreeNode(p);
                                    }

    Avoid deeply nested control flow statements.
    Open

                            if (busy == 0 && casBusy()) {
                                boolean created = false;
                                try {               // Recheck under lock
                                    Cell[] rs; int m, j;
                                    if ((rs = cells) != null &&

      Avoid deeply nested control flow statements.
      Open

                                          if (count >= TREE_THRESHOLD)
                                              replaceWithTreeBin(tab, i, k);

        Method nsWait has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                @JRubyMethod(name = "ns_wait", optional = 1, visibility = Visibility.PROTECTED)
                public IRubyObject nsWait(ThreadContext context, IRubyObject[] args) {
                    Ruby runtime = context.runtime;
                    if (args.length > 1) {
                        throw runtime.newArgumentError(args.length, 1);
        Severity: Minor
        Found in ext/concurrent-ruby/com/concurrent_ruby/ext/SynchronizationLibrary.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                                if (count >= TREE_THRESHOLD)
                                                    replaceWithTreeBin(tab, i, k);

          Avoid deeply nested control flow statements.
          Open

                                      if (!collide && q != null && q.hash == p.hash)
                                          collide = true;

            Avoid deeply nested control flow statements.
            Open

                                                if ((e.val = v) == null) {
                                                    deleted = true;
                                                    Node en = e.next;
                                                    if (pred != null)
                                                        pred.next = en;

              Avoid deeply nested control flow statements.
              Open

                                      for (Node e = tabAt(tab, i); e != null; e = e.next) {
                                          if (++c > TREE_THRESHOLD &&
                                                  (e.key instanceof Comparable)) {
                                              replaceWithTreeBin(tab, i, e.key);
                                              break;

                Method para_prepare has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                def para_prepare(&block)
                  num_threads = $conf[:num_threads]
                  count = $conf[:count_per_thread]
                
                  if num_threads % 2 > 0
                Severity: Minor
                Found in examples/benchmark_atomic_1.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                                        if (busy == 0 && casBusy()) {
                                            boolean created = false;
                                            try {               // Recheck under lock
                                                Cell[] rs; int m, j;
                                                if ((rs = cells) != null &&
                Severity: Major
                Found in ext/concurrent-ruby/com/concurrent_ruby/ext/jsr166e/Striped64.java - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                      if (count >= TREE_THRESHOLD)
                                                          replaceWithTreeBin(tab, i, k);

                    Method writeObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @SuppressWarnings("unchecked") private void writeObject(java.io.ObjectOutputStream s)
                                throws java.io.IOException {
                            if (segments == null) { // for serialization compatibility
                                segments = (Segment<K,V>[])
                                        new Segment<?,?>[DEFAULT_CONCURRENCY_LEVEL];

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                                if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
                                                    return r;
                                                else // continue descending down the left subtree
                                                    dir = -1;

                      Avoid deeply nested control flow statements.
                      Open

                                                  if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
                                                      return r;
                                                  else // continue descending down the left subtree
                                                      dir = -1;

                        Avoid deeply nested control flow statements.
                        Open

                                                    if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
                                                        return r;
                                                    // try to continue iterating on the left side
                                                    else if ((pl = p.left) != null && h <= pl.hash)
                                                        dir = -1;

                          Method writeObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              @SuppressWarnings("unchecked") private void writeObject(java.io.ObjectOutputStream s)
                                      throws java.io.IOException {
                                  if (segments == null) { // for serialization compatibility
                                      segments = (Segment<K,V>[])
                                              new Segment<?,?>[DEFAULT_CONCURRENCY_LEVEL];

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method ns_initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def ns_initialize(opts)
                                @min_length      = opts.fetch(:min_threads, DEFAULT_MIN_POOL_SIZE).to_i
                                @max_length      = opts.fetch(:max_threads, DEFAULT_MAX_POOL_SIZE).to_i
                                @idletime        = opts.fetch(:idletime, DEFAULT_THREAD_IDLETIMEOUT).to_i
                                @max_queue       = opts.fetch(:max_queue, DEFAULT_MAX_QUEUE_SIZE).to_i
                          Severity: Minor
                          Found in lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid deeply nested control flow statements.
                          Open

                                          @ReadQueue.ns_wait if running_writer?
                          Severity: Major
                          Found in lib/concurrent-ruby/concurrent/atomic/reentrant_read_write_lock.rb - About 45 mins to fix

                            Method resolve_with has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def resolve_with(state, raise_on_reassign = true, reserved = false)
                                    if compare_and_set_internal_state(reserved ? RESERVED : PENDING, state)
                                      # go to synchronized block only if there were waiting threads
                                      @Lock.synchronize { @Condition.broadcast } unless @Waiters.value == 0
                                      call_callbacks state
                            Severity: Minor
                            Found in lib/concurrent-ruby/concurrent/promises.rb - About 45 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method link has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def link(pid)
                                    return true if pid == @Pid
                                    if @Linked.add? pid
                                      pid.tell Link.new(@Pid)
                                      if pid.terminated.resolved?
                            Severity: Minor
                            Found in lib/concurrent-ruby-edge/concurrent/edge/erlang_actor.rb - About 45 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language