jdantonio/concurrent-ruby

View on GitHub

Showing 303 of 498 total issues

Avoid deeply nested control flow statements.
Open

                            if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
                                return r;
                            else // continue descending down the left subtree
                                dir = -1;

    Method writeObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        @SuppressWarnings("unchecked") private void writeObject(java.io.ObjectOutputStream s)
                throws java.io.IOException {
            if (segments == null) { // for serialization compatibility
                segments = (Segment<K,V>[])
                        new Segment<?,?>[DEFAULT_CONCURRENCY_LEVEL];

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                                        if ((e.val = v) == null) {
                                            deleted = true;
                                            Node en = e.next;
                                            if (pred != null)
                                                pred.next = en;

      Avoid deeply nested control flow statements.
      Open

                              for (Node e = tabAt(tab, i); e != null; e = e.next) {
                                  if (++c > TREE_THRESHOLD &&
                                          (e.key instanceof Comparable)) {
                                      replaceWithTreeBin(tab, i, e.key);
                                      break;

        Avoid deeply nested control flow statements.
        Open

                                    if (!collide && q != null && q.hash == p.hash)
                                        collide = true;

          Avoid deeply nested control flow statements.
          Open

                                              if (count >= TREE_THRESHOLD)
                                                  replaceWithTreeBin(tab, i, k);

            Avoid deeply nested control flow statements.
            Open

                                                if ((p.val = v) == null) {
                                                    deleted = true;
                                                    t.deleteTreeNode(p);
                                                }

              Avoid deeply nested control flow statements.
              Open

                                                  if ((p.val = v) == null) {
                                                      deleted = true;
                                                      t.deleteTreeNode(p);
                                                  }

                Avoid deeply nested control flow statements.
                Open

                                        if (busy == 0 && casBusy()) {
                                            boolean created = false;
                                            try {               // Recheck under lock
                                                Cell[] rs; int m, j;
                                                if ((rs = cells) != null &&

                  Avoid deeply nested control flow statements.
                  Open

                                                          if (count >= TREE_THRESHOLD)
                                                              replaceWithTreeBin(tab, i, k);

                    Avoid deeply nested control flow statements.
                    Open

                                                if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
                                                    return r;
                                                // try to continue iterating on the left side
                                                else if ((pl = p.left) != null && h <= pl.hash)
                                                    dir = -1;

                      Avoid deeply nested control flow statements.
                      Open

                                                          if ((e.val = v) == null) {
                                                              deleted = true;
                                                              Node en = e.next;
                                                              if (pred != null)
                                                                  pred.next = en;

                        Avoid deeply nested control flow statements.
                        Open

                                                for (Node e = tabAt(tab, i); e != null; e = e.next) {
                                                    if (++c > TREE_THRESHOLD &&
                                                            (e.key instanceof Comparable)) {
                                                        replaceWithTreeBin(tab, i, e.key);
                                                        break;

                          Method writeObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              @SuppressWarnings("unchecked") private void writeObject(java.io.ObjectOutputStream s)
                                      throws java.io.IOException {
                                  if (segments == null) { // for serialization compatibility
                                      segments = (Segment<K,V>[])
                                              new Segment<?,?>[DEFAULT_CONCURRENCY_LEVEL];

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid deeply nested control flow statements.
                          Open

                                                      if ((pr = p.right) != null && h >= pr.hash && (r = getTreeNode(h, k, pr)) != null)
                                                          return r;
                                                      else // continue descending down the left subtree
                                                          dir = -1;

                            Method para_prepare has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                            Open

                            def para_prepare(&block)
                              num_threads = $conf[:num_threads]
                              count = $conf[:count_per_thread]
                            
                              if num_threads % 2 > 0
                            Severity: Minor
                            Found in examples/benchmark_atomic_1.rb - About 45 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Avoid deeply nested control flow statements.
                            Open

                                                                    if (count >= TREE_THRESHOLD)
                                                                        replaceWithTreeBin(tab, i, k);

                              Method ns_wait_until has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                                    def ns_wait_until(timeout = nil, &condition)
                                      if timeout
                                        wait_until = Concurrent.monotonic_time + timeout
                                        loop do
                                          now = Concurrent.monotonic_time

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method on_envelope has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                                      def on_envelope(envelope)
                                        command, reason = envelope.message
                                        case command
                                        when :terminated?
                                          terminated?
                              Severity: Minor
                              Found in lib/concurrent-ruby-edge/concurrent/actor/behaviour/termination.rb - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method consume_signal has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                                    def consume_signal(message)
                                      if AbstractSignal === message
                                        case message
                                        when Ask
                                          @reply = message.probe
                              Severity: Minor
                              Found in lib/concurrent-ruby-edge/concurrent/edge/erlang_actor.rb - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language