jeka-r/project-lvl2-s18

View on GitHub
src/formaters/defaultformater.js

Summary

Maintainability
D
2 days
Test Coverage

Function iter has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const iter = (array, level) => {
    const str = array.reduce((acc, item) => {
      const tab = _repeat(' ', 4 * level);
      const deepTab = _repeat(' ', 4 * (level + 1));
      if (item.children.length > 0) {
Severity: Minor
Found in src/formaters/defaultformater.js - About 1 hr to fix

    Function str has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const str = array.reduce((acc, item) => {
          const tab = _repeat(' ', 4 * level);
          const deepTab = _repeat(' ', 4 * (level + 1));
          if (item.children.length > 0) {
            return `${acc}    ${item.key}: {\n${iter(item.children, level + 1)}    ${tab}}\n`;
    Severity: Minor
    Found in src/formaters/defaultformater.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return `${acc}${oldValueStr}`;
      Severity: Major
      Found in src/formaters/defaultformater.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return `${acc}${newValueStr}${oldValueStr}`;
        Severity: Major
        Found in src/formaters/defaultformater.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return `${acc}${valueStr}`;
          Severity: Major
          Found in src/formaters/defaultformater.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (item.status === 'removed') {
                    if (item.oldValue instanceof Object) {
                      const objStr = JSON.stringify(item.oldValue, ' ', 4).split('\n').join(`\n${deepTab}`);
                      const valueStr = `${tab}  - ${item.key}: ${objStr}\n`;
                      return `${acc}${valueStr}`;
            Severity: Major
            Found in src/formaters/defaultformater.js and 1 other location - About 6 hrs to fix
            src/formaters/defaultformater.js on lines 12..20

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 168.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (item.status === 'added') {
                    if (item.newValue instanceof Object) {
                      const objStr = JSON.stringify(item.newValue, ' ', 4).split('\n').join(`\n${deepTab}`);
                      const valueStr = `${tab}  + ${item.key}: ${objStr}\n`;
                      return `${acc}${valueStr}`;
            Severity: Major
            Found in src/formaters/defaultformater.js and 1 other location - About 6 hrs to fix
            src/formaters/defaultformater.js on lines 22..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 168.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status