Sign upLogin

jeka-r/project-lvl2-s18

View on GitHub
Star
src/gendiff.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function compare has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const compare = (preparedDataBefore, preparedDataAfter, acum) => {
  const keysBeforeData = Object.keys(preparedDataBefore);
  const keysAfterData = Object.keys(preparedDataAfter);
  const unionKeys = _union(keysBeforeData, keysAfterData);
  const astTree = unionKeys.reduce((acc, item) => {
Severity: Minor
Found in src/gendiff.js - About 1 hr to fix

    Function astTree has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const astTree = unionKeys.reduce((acc, item) => {
    if (preparedDataBefore[item] !== preparedDataAfter[item]) {
      if (preparedDataAfter[item] instanceof Object && preparedDataBefore[item] instanceof Object) {
        return [...acc, {
          status: 'unchanged',
    Severity: Minor
    Found in src/gendiff.js - About 1 hr to fix

      Function compare has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      const compare = (preparedDataBefore, preparedDataAfter, acum) => {
  const keysBeforeData = Object.keys(preparedDataBefore);
  const keysAfterData = Object.keys(preparedDataAfter);
  const unionKeys = _union(keysBeforeData, keysAfterData);
  const astTree = unionKeys.reduce((acc, item) => {
      Severity: Minor
      Found in src/gendiff.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return [...acc, {
      status: 'unchanged',
      key: item,
      newValue: null,
      oldValue: preparedDataBefore[item],
      Severity: Major
      Found in src/gendiff.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status