Showing 2 of 2 total issues
Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def initialize(username, thing_id, params = {})
if invalid_username(username) && invalid_id(thing_id)
raise ArgumentError.new 'missing required argument'
else
params[:username] = username unless invalid_username username- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method user_rated has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def user_rated(value = nil)
@items.select do |item|
if value.kind_of? Range and !item.user_rating.nil?
value.include? item.user_rating.floor
elsif value.kind_of? Integer and !item.user_rating.nil?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"